Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nixpkgs backports #1323

Closed
wants to merge 1 commit into from
Closed

Conversation

purcell
Copy link
Member

@purcell purcell commented Sep 24, 2023

There seem to have been some changes made to the poetry2nix overrides in nixpkgs over the last 3 months, and I guess we want them here too, in order to have this repo be the ultimate source of truth?

NixOS/nixpkgs@b9b3be8e099f
NixOS/nixpkgs@6b63908
NixOS/nixpkgs@253a291

@purcell purcell force-pushed the nixpkgs-backports branch 2 times, most recently from 280c537 to 50b814f Compare September 24, 2023 08:30
@purcell
Copy link
Member Author

purcell commented Sep 24, 2023

Alright, so the wheel change from downstream fails the tests here. Is this PR misguided? What's the plan for getting updates from here into nixpkgs now? It seems the release numbering scheme changed in June and there haven't been any syncs into nixpkgs from here since then.

@andersk
Copy link
Contributor

andersk commented Sep 25, 2023

See also #1291; there was a corresponding update to python3.pkgs.wheel, so we need to update our nixpkgs commit at the same time.

@purcell
Copy link
Member Author

purcell commented Sep 25, 2023

so we need to update our nixpkgs commit at the same time.

Oh, I see, you mean the pinned version used in CI here. Makes sense. I'll add a commit here which bumps the flake deps, but I'll leave it to @adisbladis / @cpcloud to suggest how best to coordinate all this.

@purcell
Copy link
Member Author

purcell commented Sep 25, 2023

Hmm, if that was indeed the suggestion, it didn't fix the build issue. I'll back out that commit to minimise the noise.

@andersk
Copy link
Contributor

andersk commented Sep 25, 2023

Well yeah, there seem to be other issues with bumping the nixpkgs commit, which is why I linked #1291.

@cpcloud
Copy link
Collaborator

cpcloud commented Oct 25, 2023

Closing this out in favor of #1329.

@cpcloud cpcloud closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants