Upstream overrides

[PerchunPak]

These are overrides I made for my projects, just upstreaming them

[adisbladis]

This is using IFD. Please use cargoVendorHash instead.

[PerchunPak]

You mean cargoHash? I cannot find anything about cargoVendorHash in nixpkgs

[PerchunPak]

I assume you meant pkgs.rustPlatform.fetchCargoTarball, but why? importCargoLock gives an ability to have less maintenance burden because of not having hash for every single release. This would still be reproducible, as hashes are in poetry.lock, but also will make that any new version of libcst is automatically supported:

libcst = prev.libcst.overridePythonAttrs (
  old: lib.optionalAttrs (!(old.src.isWheel or false)) (
    let
      unpackedSrc = stdenv.mkDerivation {
        name = "unpacked-${old.src.name}";
        inherit (old) src;
        buildPhase = "cp -r . $out";
      };
    in
    {
      cargoDeps = pkgs.rustPlatform.importCargoLock {
        lockFile = "${unpackedSrc.out}/native/Cargo.lock";
      };
      cargoRoot = "native";
      nativeBuildInputs = old.nativeBuildInputs or [ ] ++ [
        pkgs.rustPlatform.cargoSetupHook # handles `importCargoLock`
        pkgs.rustc
        pkgs.cargo
      ];
    }
  )
);

There are also multiple other places, where poetry2nix could automatically get dependencies, but instead you chose to manually add them to every package. E.g. if poetry or setuptools are required for build: https://github.com/py-mine/mcstatus/blob/0bbd4842178fa1db252371ce5599651e4b867efd/pyproject.toml#L164

[spinus]

@adisbladis can you elaborate?

[PerchunPak]

I learned about IFD since then and will try to fix the issue

[PerchunPak]

Should I add an IFD alternative for versions older than 1.0.0? (libcst is not that popular after all)

$ du -sh overrides/libcst
348K	overrides/libcst