Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overrides: update build system for propcache #1847

Merged
merged 2 commits into from
Oct 25, 2024
Merged

overrides: update build system for propcache #1847

merged 2 commits into from
Oct 25, 2024

Conversation

davejames
Copy link
Contributor

@davejames davejames commented Oct 14, 2024 •
edited by cpcloud
Loading

python versions <= 3.11 require tomli at build
https://github.com/aio-libs/propcache/blob/f5ba26cc63f4069473cf322c1b1c1924dec941de/pyproject.toml#L8

Contribution checklist (recommended but not always applicable/required):

  • There's an automated test for this change
  • Commit messages or code include references to related issues or PRs (including third parties)
  • Commit messages are conventional - examples from the log include "feat: add changelog files to fixup hook", "fix(contourpy): allow wheel usage", and "test: add sqlalchemy2 test"

cpcloud
cpcloud previously approved these changes Oct 16, 2024
View reviewed changes
@cpcloud cpcloud dismissed their stale review October 16, 2024 10:15

Incorrectly accepted

cpcloud
cpcloud requested changes Oct 16, 2024
View reviewed changes
overrides/build-systems.json Outdated Show resolved Hide resolved
@cpcloud cpcloud force-pushed the overrides_propcache branch from 86dc757 to 46a27f5 Compare October 17, 2024 10:14
cpcloud
cpcloud previously approved these changes Oct 17, 2024
View reviewed changes
@davejames davejames force-pushed the overrides_propcache branch from 46a27f5 to 9ebc598 Compare October 25, 2024 11:18
@davejames
Copy link
Contributor Author

@cpcloud rebased and resolved conflicts. the macos-13 test now passes too

@cpcloud cpcloud merged commit bd04220 into nix-community:master Oct 25, 2024
188 checks passed
@davejames davejames deleted the overrides_propcache branch October 26, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcloud cpcloud cpcloud left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davejames @cpcloud