Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not reuse the buffer in the inner loop #8

Closed
wants to merge 2 commits into from
Closed

fix: do not reuse the buffer in the inner loop #8

wants to merge 2 commits into from

Conversation

acristoffers
Copy link

Fixes #6

Not reusing the buffer solved the issue.

@acristoffers
Copy link
Author

Since this pull request is about compatibility with Zig's new build.zig.zon format, I also added a fix to .path now being accepted instead of a url/hash pair. From my testing we just need to ignore it, since it accepts paths relative to the build root and does not copy anything anywhere.

@acristoffers acristoffers mentioned this pull request Nov 26, 2023
Closed
angaz
angaz approved these changes Mar 23, 2024
View reviewed changes
Copy link

@angaz angaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a problem with using multiple packages in the build.zig.zon file.
This PR fixes it. I hope it gets merged soon.

@acristoffers acristoffers closed this by deleting the head repository Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angaz angaz angaz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Runtime error
2 participants
@acristoffers @angaz