Add Libvirt container and compile the installer #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The added container can be used to run the installer. Note: This container doesn't include the required deps for compiling the installer. Signed-off-by: gbenhaim <[email protected]>
|
@cynepco3hahue any idea how do I fix the import path? |
|
the absolute path of the installer must be |
Added a build container for building the installer. Signed-off-by: gbenhaim <[email protected]>
Signed-off-by: gbenhaim <[email protected]>
Configuring NetwrokManager during build time can damage DNS configuration since we don't now what will be the DNS servers when the container will be started. Since only virsh configuration was left in setup.sh, move it also to runtime so we can remove setup.sh. Signed-off-by: gbenhaim <[email protected]>
gbenhaim
force-pushed
the
compile
branch
2 times, most recently
from
10adfef to
be5e80a
Compare
|
ci test please |
Signed-off-by: gbenhaim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.