Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for bing map url quadkey in ros1 branch #126

Open
wants to merge 3 commits into
base: ros1
Choose a base branch
from

Conversation

shupx
Copy link

@shupx shupx commented Sep 10, 2024

The bing map uses quadkey rather than tile xyz. The new commit adds support for the bing map quadkey in ros1 branch. For example, you can use the following bing satellite map url now:

http://ecn.t3.tiles.virtualearth.net/tiles/a{q}.jpeg?g=1

, where {q} is the quadkey.

@Timple
Copy link
Member

Timple commented Sep 10, 2024

Cool!

Would you mind making the same change for ROS2?

@shupx
Copy link
Author

shupx commented Sep 11, 2024

Sorry. I am not familiar with ROS2 now.

Hope the ROS1 commit can be merged to the branch. haha

@Timple
Copy link
Member

Timple commented Sep 12, 2024

Alright, I'll do a review and forward port myself.

src/tile_id.cpp Show resolved Hide resolved
src/tile_id.cpp Show resolved Hide resolved
src/tile_id.cpp Outdated Show resolved Hide resolved
src/tile_id.cpp Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants