Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and Enhance #19

Merged
merged 39 commits into from
Aug 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
a5befd1
config: update gitignore and DESCRIPTION
jimbrig Aug 29, 2024
cc328df
feat: add new `entrata_api.R` with R6 class
jimbrig Aug 29, 2024
490fdad
docs: add man pages for new R6 class
jimbrig Aug 29, 2024
3c6273e
docs: add initial vignette and assets
jimbrig Aug 29, 2024
02d39c7
tests: update test for leases
jimbrig Aug 29, 2024
ea8961e
feat: starting to add json schemas
jimbrig Aug 29, 2024
b02949b
feat: major refactoring
jimbrig Aug 29, 2024
3b0f8a4
misc
jimbrig Aug 29, 2024
0d504dd
Update documentation
jimbrig Aug 29, 2024
bed6866
data: add misc working xlsx files
jimbrig Aug 29, 2024
ff3d52d
Merge branch 'develop' of https://github.com/noclocks/gmhleasr into d…
jimbrig Aug 29, 2024
968c197
Update documentation
jimbrig Aug 29, 2024
1141fd8
feat: add multi-pkgdown
jimbrig Aug 29, 2024
9bc194f
Merge branch 'develop' of https://github.com/noclocks/gmhleasr into d…
jimbrig Aug 29, 2024
1644d78
docs: update README
jimbrig Aug 29, 2024
8a06dd7
docs: vignettes
jimbrig Aug 29, 2024
517f202
Style code (GHA)
jimbrig Aug 29, 2024
b896699
docs: updated man pages
jimbrig Aug 29, 2024
4a3fc9e
bug: fix and refactor
jimbrig Aug 29, 2024
e915788
feat: update core request function
jimbrig Aug 29, 2024
03df184
test: add cfg_test
jimbrig Aug 29, 2024
04b0a29
test: add tests for new R6
jimbrig Aug 29, 2024
447c86e
bug: fix leases test
jimbrig Aug 29, 2024
b2dc61c
placeholder redact
jimbrig Aug 29, 2024
74517f6
tests: refactor all tests with new mocking setup
jimbrig Aug 29, 2024
cedcdfc
Merge branch 'develop' of https://github.com/noclocks/gmhleasr into d…
jimbrig Aug 29, 2024
36a4307
Style code (GHA)
jimbrig Aug 29, 2024
9146ec0
tests: cleanup
jimbrig Aug 29, 2024
7687161
Style code (GHA)
jimbrig Aug 29, 2024
428ca56
feat: updates and fixes related to tests
jimbrig Aug 29, 2024
e216c96
Merge branch 'develop' of https://github.com/noclocks/gmhleasr into d…
jimbrig Aug 29, 2024
7c9bfeb
Style code (GHA)
jimbrig Aug 29, 2024
3dd32f4
feat: add teardown for config decryption, memoized helpers in onLoad,…
jimbrig Aug 29, 2024
11c552e
Style code (GHA)
jimbrig Aug 29, 2024
c827082
config: configure lintr
jimbrig Aug 29, 2024
b73265d
Merge branch 'develop' of https://github.com/noclocks/gmhleasr into d…
jimbrig Aug 29, 2024
0f6e5c5
feat: update all GHA
jimbrig Aug 29, 2024
a007072
docs: update badges
jimbrig Aug 29, 2024
7a43270
docs: badges
jimbrig Aug 29, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,5 @@
^docs$
^pkgdown$
^Makefile$
^CHANGELOG\.md$
^\.lintr$
1 change: 1 addition & 0 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ jobs:
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
R_KEEP_PKG_SOURCE: yes
NOCLOCKS_ENCRYPTION_KEY: ${{ secrets.NOCLOCKS_ENCRYPTION_KEY }}

steps:
- uses: actions/checkout@v4
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@
# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help
on:
push:
branches: [main]
branches: [main, develop]
pull_request:
branches: [main]
branches: [main, develop]
workflow_dispatch:

name: Test Coverage
Expand All @@ -16,6 +16,7 @@ jobs:
runs-on: ubuntu-latest
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
NOCLOCKS_ENCRYPTION_KEY: ${{ secrets.NOCLOCKS_ENCRYPTION_KEY }}

steps:
- uses: actions/checkout@v4
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ jobs:
runs-on: ubuntu-latest
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
NOCLOCKS_ENCRYPTION_KEY: ${{ secrets.NOCLOCKS_ENCRYPTION_KEY }}

steps:
- uses: actions/checkout@v4

Expand All @@ -32,4 +34,4 @@ jobs:
run: lintr::lint_package()
shell: Rscript {0}
env:
LINTR_ERROR_ON_LINT: true
LINTR_ERROR_ON_LINT: false
Loading
Loading