Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[attention] Fix tuning and add flags #18

Merged
merged 3 commits into from
Oct 15, 2024
Merged

[attention] Fix tuning and add flags #18

merged 3 commits into from
Oct 15, 2024

Conversation

Groverkss
Copy link
Contributor

  • Fix tuning spec
  • Add flag for perf
  • Add a dummy generation test to attention_utils

kuhar
kuhar reviewed Oct 8, 2024
View reviewed changes
attentionbench/attention_utils.py Outdated Show resolved Hide resolved
attentionbench/attention_utils.py Outdated Show resolved Hide resolved
@Groverkss Groverkss force-pushed the attention-tuning-fix branch from 421d1b1 to b7ab437 Compare October 15, 2024 15:29
@Groverkss Groverkss requested review from kuhar and saienduri October 15, 2024 15:29
@Groverkss Groverkss merged commit 0aa226d into main Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhar kuhar kuhar approved these changes

@saienduri saienduri Awaiting requested review from saienduri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Groverkss @kuhar @saienduri