Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update memory report to run noir-contracts repo #6809

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

vezenovm
Copy link
Contributor

@vezenovm vezenovm commented Dec 13, 2024

Description

Problem*

Resolves #6883

Summary*

I just saw #6807 and noticed that ram_blowup_regression went down by 50%. I remembered that this is a pattern common in the noir contracts so I want to test bringing back the noir-contracts repo to the memory report. Previously it took just under 30 minutes and had a peak memory of ~9 GB.

After #6875 the report now finishes in the CI report. It finishes in ~28 minutes.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Compilation Sample

Program Compilation Time %
sha256_regression 1.460s 1%
regression_4709 0.829s 0%
ram_blowup_regression 16.051s -1%
rollup-base-public 127.104s -6%
rollup-base-private 108.413s -4%
private-kernel-tail 1.121s 6%
private-kernel-reset 8.324s 1%
private-kernel-inner 2.309s 3%
parity-root 0.733s -5%
noir-contracts 91.986s -1%

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Peak Memory Sample

Program Peak Memory
keccak256 78.56M
workspace 123.34M
regression_4709 423.67M
ram_blowup_regression 1.58G
private-kernel-tail 207.23M
private-kernel-reset 720.82M
private-kernel-inner 292.44M
parity-root 172.24M
noir-contracts 6.49G

@vezenovm
Copy link
Contributor Author

Ok looks like the noir-contracts memory report still did not finish

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Execution Sample

Program Execution Time %
sha256_regression 0.628s 0%
regression_4709 0.395s 0%
ram_blowup_regression 4.375s -1%
rollup-base-public 21.249s 0%
rollup-base-private 19.189s 0%
private-kernel-tail 0.698s -3%
private-kernel-reset 1.495s 0%
private-kernel-inner 0.973s 1%
parity-root 0.523s -4%

@vezenovm vezenovm marked this pull request as ready for review December 19, 2024 19:56
@vezenovm
Copy link
Contributor Author

It still takes about 28 minutes to generate the report @TomAFrench. Not sure if we want to merge this to run like every other report. If we do, then this report will become the bottleneck for CI.

@TomAFrench
Copy link
Member

Yeah I agree 28 minutes is too much.

@TomAFrench
Copy link
Member

We may want to pull out a couple of contracts in particular that are interesting but running a whole workspace is a waste of time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add noir-contracts to memory report
2 participants