Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Test new bench report only showing seconds #6881

Closed
wants to merge 1 commit into from

Conversation

vezenovm
Copy link
Contributor

@vezenovm vezenovm commented Dec 19, 2024

Description

Problem*

I opened this PR just to test against #6880. All diffs in that PR (#6880 (comment)) are reporting a diff percentage of infinity. This is due to us needing special handling for the old report that has minutes as part of its time.

Summary*

I want to see whether we can generate an accurate report with by opening up a child report alone and without having to do any special handling in https://github.com/noir-lang/noir-bench-report

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Peak Memory Sample

Program Peak Memory
keccak256 78.56M
workspace 123.68M
regression_4709 423.67M
ram_blowup_regression 1.58G
private-kernel-tail 207.23M
private-kernel-reset 720.82M
private-kernel-inner 292.44M
parity-root 172.24M

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Compilation Sample

Program Compilation Time %
sha256_regression 1.469s -2%
regression_4709 0.821s -3%
ram_blowup_regression 16.056s -1%
rollup-base-public 129.569s -3%
rollup-base-private 119.831s 10%
private-kernel-tail 1.050s -6%
private-kernel-reset 7.837s -7%
private-kernel-inner 2.318s -1%
parity-root 0.741s -5%
noir-contracts 91.183s -7%

Copy link
Contributor

github-actions bot commented Dec 19, 2024

Execution Sample

Program Execution Time %
sha256_regression 0.619s 0%
regression_4709 0.393s -4%
ram_blowup_regression 4.372s 0%
rollup-base-public 21.107s 0%
rollup-base-private 19.346s 0%
private-kernel-tail 0.690s -1%
private-kernel-reset 1.458s -3%
private-kernel-inner 0.987s -1%
parity-root 0.530s -2%

@vezenovm
Copy link
Contributor Author

These reports are displayed accurately so closing and we can merge the parent

@vezenovm vezenovm closed this Dec 19, 2024
@vezenovm vezenovm reopened this Dec 19, 2024
@vezenovm vezenovm closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant