Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refined text by fixing typos and improving clarity #6885

Closed
wants to merge 6 commits into from
+6 −6
Closed

Refined text by fixing typos and improving clarity #6885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9b734de
Update codegen-verifiers.sh
dannbbb1 Dec 19, 2024
e40251e
Update recursion.test.ts
dannbbb1 Dec 19, 2024
228066a
Update onchain_recursive_verification.test.ts
dannbbb1 Dec 19, 2024
ee38d3d
Update smart_contract_verifier.test.ts
dannbbb1 Dec 19, 2024
0478882
Update abi_gen.rs
dannbbb1 Dec 19, 2024
ccfcce8
Update recursion.test.ts
dannbbb1 Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions compiler/integration-tests/scripts/codegen-verifiers.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@ $NARGO_BACKEND_PATH contract -k $KEYS/assert_statement -o $contracts_dir/assert_
recursion_dir=$repo_root/compiler/integration-tests/circuits/recursion
nargo --program-dir $recursion_dir compile
$NARGO_BACKEND_PATH write_vk -b $recursion_dir/target/recursion.json -o $KEYS/recursion
$NARGO_BACKEND_PATH contract -k $KEYS/recursion ./ -o $contracts_dir/recursion.sol
$NARGO_BACKEND_PATH contract -k $KEYS/recursion -o $contracts_dir/recursion.sol

rm -rf $KEYS
rm -rf $KEYS
2 changes: 1 addition & 1 deletion compiler/integration-tests/test/browser/recursion.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint-disable @typescript-eslint/ban-ts-comment */
/* eslint-disable @typescript-eslint/ban-ts-comments */
import { expect } from '@esm-bundle/chai';
import { TEST_LOG_LEVEL } from '../environment.js';
import { Logger } from 'tslog';
Expand Down
2 changes: 1 addition & 1 deletion compiler/integration-tests/test/node/onchain_recursive_verification.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { ethers } from 'hardhat';

import { readFileSync } from 'node:fs';
import { resolve, join } from 'path';
import toml from 'toml';
import * as TOML from 'smol-toml';

import { Noir } from '@noir-lang/noir_js';
import { UltraPlonkBackend } from '@aztec/bb.js';
Expand Down
2 changes: 1 addition & 1 deletion compiler/integration-tests/test/node/smart_contract_verifier.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { ethers } from 'hardhat';

import { readFileSync } from 'node:fs';
import { resolve } from 'path';
import toml from 'toml';
import * as TOML from 'smol-toml';

import { Noir } from '@noir-lang/noir_js';
import { UltraPlonkBackend } from '@aztec/bb.js';
Expand Down
2 changes: 1 addition & 1 deletion compiler/noirc_driver/src/abi_gen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ pub(super) fn abi_type_from_hir_type(context: &Context, typ: &Type) -> AbiType {
let span = get_main_function_span(context);
let length = size
.evaluate_to_u32(span)
.expect("Cannot have variable sized arrays as a parameter to main");
.expect("Cannot have variable-sized arrays as a parameter to main");
let typ = typ.as_ref();
AbiType::Array { length, typ: Box::new(abi_type_from_hir_type(context, typ)) }
}
Expand Down
Loading