Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bigint builtins are foreigns #6892

Merged
merged 5 commits into from
Dec 23, 2024
Merged

fix: bigint builtins are foreigns #6892

merged 5 commits into from
Dec 23, 2024

Conversation

guipublic
Copy link
Contributor

Description

Problem*

Resolves #6594

Summary*

I just changed the attribute, foreign and builtin are handled almost identically.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

github-actions bot commented Dec 20, 2024

Peak Memory Sample

Program Peak Memory
keccak256 78.48M
workspace 123.33M
regression_4709 422.91M
ram_blowup_regression 1.58G
private-kernel-tail 201.61M
private-kernel-reset 716.87M
private-kernel-inner 291.68M
parity-root 171.93M

Copy link
Contributor

github-actions bot commented Dec 20, 2024

Execution Sample

Program Execution Time %
sha256_regression 0.623s 1%
regression_4709 0.393s 3%
ram_blowup_regression 4.316s -3%
rollup-base-public 20.797s -2%
rollup-base-private 18.517s -5%
private-kernel-tail 0.683s -3%
private-kernel-reset 1.454s -2%
private-kernel-inner 0.982s -1%
parity-root 0.529s -1%

Copy link
Contributor

github-actions bot commented Dec 20, 2024

Compilation Sample

Program Compilation Time %
sha256_regression 1.347s 2%
regression_4709 0.785s 1%
ram_blowup_regression 15.364s 0%
rollup-base-public 114.197s 2%
rollup-base-private 94.052s -5%
private-kernel-tail 1.014s -2%
private-kernel-reset 7.132s -3%
private-kernel-inner 2.198s 1%
parity-root 0.730s -8%
noir-contracts 88.317s 3%

@TomAFrench
Copy link
Member

We needed to take on some tech debt with this fallback handler here:

blackbox if BlackBoxFunc::is_valid_black_box_func_name(blackbox) => {
self.call_foreign(blackbox, arguments, return_type, location)
}

We should remove this in this PR to make sure that we've got all of the instances of this issue.

@guipublic
Copy link
Contributor Author

We should remove this in this PR to make sure that we've got all of the instances of this issue.

Done

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 23, 2024
@guipublic
Copy link
Contributor Author

I dont't understand why CI is failing on some boundedvev doc that is not modified here, but anyways I fixed the typo in the doc.

@TomAFrench
Copy link
Member

I dont't understand why CI is failing on some boundedvev doc that is not modified here, but anyways I fixed the typo in the doc.

Thanks, I think this got affected by the release PR which got merged.

@TomAFrench TomAFrench enabled auto-merge December 23, 2024 16:58
@TomAFrench TomAFrench added this pull request to the merge queue Dec 23, 2024
Copy link
Contributor

Copy link
Contributor

FYI @noir-lang/developerrelations on Noir doc changes.

Merged via the queue into master with commit a1f9c94 Dec 23, 2024
85 checks passed
@TomAFrench TomAFrench deleted the gd/issue_6594 branch December 23, 2024 17:08
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 24, 2024
…ked protocol circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 24, 2024
… circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 25, 2024
…ked protocol circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 25, 2024
… circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 26, 2024
…ked protocol circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 26, 2024
… circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 27, 2024
…ked protocol circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 27, 2024
… circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 28, 2024
…ked protocol circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 28, 2024
… circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 29, 2024
…ked protocol circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 29, 2024
… circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 30, 2024
…ked protocol circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 30, 2024
… circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 31, 2024
…ked protocol circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 31, 2024
… circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some builtin functions are actually foreign
2 participants