chore: Add `Instruction::Noop` #6899

jfecher · 2024-12-20T19:44:38Z

Description

Problem*

Resolves #6842

Summary*

Not expected to affect things much, but adds a no-op instruction to ssa as an alternative to the instructions.retain(..) pattern. Currently I've only changed 2 passes to use this but we can change more in the future.

Additional Context

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

github-actions · 2024-12-20T19:48:09Z

Peak Memory Sample

Program	Peak Memory
keccak256	78.48M
workspace	123.62M
regression_4709	422.91M
ram_blowup_regression	1.58G
private-kernel-tail	201.60M
private-kernel-reset	716.87M
private-kernel-inner	291.67M
parity-root	171.93M

github-actions · 2024-12-20T19:51:26Z

Compilation Sample

Program	Compilation Time	%
sha256_regression	1.389s	3%
regression_4709	0.811s	5%
ram_blowup_regression	15.683s	1%
rollup-base-public	112.221s	-6%
rollup-base-private	99.681s	1%
private-kernel-tail	1.069s	-7%
private-kernel-reset	7.613s	5%
private-kernel-inner	2.225s	0%
parity-root	0.786s	1%
noir-contracts	85.330s	-6%

github-actions · 2024-12-20T19:51:26Z

Execution Sample

Program	Execution Time	%
sha256_regression	0.640s	1%
regression_4709	0.405s	3%
ram_blowup_regression	4.488s	-1%
rollup-base-public	21.330s	-3%
rollup-base-private	19.926s	0%
private-kernel-tail	0.712s	-2%
private-kernel-reset	1.487s	-1%
private-kernel-inner	0.980s	-2%
parity-root	0.535s	-1%

compiler/noirc_evaluator/src/ssa/ir/dfg.rs

vezenovm

Looks like we just need some extra handling for inlining

…ped so the ins cant be removed

github-actions · 2024-12-20T20:26:11Z

Changes to Brillig bytecode sizes

Generated at commit: ab288e365d1cb64098b00fe4c9ae4ec4bf00c632, compared to commit: 913be5b013323449963d31ab00f521f572cfcd67

🧾 Summary (10% most significant diffs)

Program	Brillig opcodes (+/-)	%
sha256_regression	-3 ✅	-0.04%
array_sort	-3 ✅	-1.01%

Full diff report 👇

Program	Brillig opcodes (+/-)	%
hashmap	21,810 (-3)	-0.01%
uhashmap	14,016 (-3)	-0.02%
sha256_regression	6,917 (-3)	-0.04%
array_sort	293 (-3)	-1.01%

github-actions · 2024-12-20T20:26:19Z

Changes to number of Brillig opcodes executed

Generated at commit: ab288e365d1cb64098b00fe4c9ae4ec4bf00c632, compared to commit: 913be5b013323449963d31ab00f521f572cfcd67

🧾 Summary (10% most significant diffs)

Program	Brillig opcodes (+/-)	%
hashmap	-3 ✅	-0.01%
array_sort	-3 ✅	-0.57%

Full diff report 👇

Program	Brillig opcodes (+/-)	%
uhashmap	145,608 (-3)	-0.00%
sha256_regression	128,310 (-3)	-0.00%
hashmap	54,202 (-3)	-0.01%
array_sort	523 (-3)	-0.57%

chore: Add `Instruction::Noop` (noir-lang/noir#6899)

…ked protocol circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)

… circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)

…ked protocol circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)

… circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)

…ked protocol circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)

… circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)

…ked protocol circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)

… circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)

…ked protocol circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)

… circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)

…ked protocol circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)

… circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)

…ked protocol circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)

… circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)

…ked protocol circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)

… circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)

jfecher added 2 commits December 20, 2024 13:43

Add Noop

6cad005

Replace with an empty smallvec instead

1b3ddd3

jfecher marked this pull request as ready for review December 20, 2024 19:46

vezenovm approved these changes Dec 20, 2024

View reviewed changes

compiler/noirc_evaluator/src/ssa/ir/dfg.rs Show resolved Hide resolved

vezenovm reviewed Dec 20, 2024

View reviewed changes

jfecher and others added 4 commits December 20, 2024 14:08

Merge branch 'master' into jf/noop

6a2165c

Add smallvec to cspell

3bebd7f

Merge branch 'jf/noop' of https://github.com/noir-lang/noir into jf/noop

ca1372c

Undo as_slice_length change, only the length and not the slice is map…

d65d9b6

…ped so the ins cant be removed

jfecher added 2 commits December 20, 2024 14:30

Re-add replace_result, revert as_slice_length

043459d

Remove extra newline

023f4a7

jfecher enabled auto-merge December 20, 2024 20:38

jfecher added this pull request to the merge queue Dec 20, 2024

Merged via the queue into master with commit 70b255e Dec 20, 2024
85 checks passed

jfecher deleted the jf/noop branch December 20, 2024 20:47

AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 21, 2024

[1 changes] chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)

3eddfd7

chore: Add `Instruction::Noop` (noir-lang/noir#6899)

AztecBot mentioned this pull request Dec 21, 2024

feat: Sync from noir AztecProtocol/aztec-packages#10922

Open

AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 22, 2024

[1 changes] chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)

12331a8

chore: Add `Instruction::Noop` (noir-lang/noir#6899)

AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 22, 2024

chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)

f122e71

chore: Add `Instruction::Noop` (noir-lang/noir#6899)

AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 23, 2024

[1 changes] chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)

8f5e992

chore: Add `Instruction::Noop` (noir-lang/noir#6899)

AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 23, 2024

chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)

ac58df9

chore: Add `Instruction::Noop` (noir-lang/noir#6899)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Add `Instruction::Noop` #6899

chore: Add `Instruction::Noop` #6899

jfecher commented Dec 20, 2024

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

vezenovm left a comment

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

chore: Add Instruction::Noop #6899

chore: Add Instruction::Noop #6899

Conversation

jfecher commented Dec 20, 2024

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

github-actions bot commented Dec 20, 2024 • edited Loading

Peak Memory Sample

github-actions bot commented Dec 20, 2024 • edited Loading

Compilation Sample

github-actions bot commented Dec 20, 2024 • edited Loading

Execution Sample

vezenovm left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 20, 2024 • edited Loading

Changes to Brillig bytecode sizes

🧾 Summary (10% most significant diffs)

github-actions bot commented Dec 20, 2024 • edited Loading

Changes to number of Brillig opcodes executed

🧾 Summary (10% most significant diffs)

chore: Add `Instruction::Noop` #6899

chore: Add `Instruction::Noop` #6899

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading