Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consistent file_id across installation paths #6912

Merged
merged 2 commits into from
Dec 23, 2024

Conversation

guipublic
Copy link
Contributor

Description

Problem*

Resolves an issue where monomorphisation hash differ between compilations from different installation folders

Summary*

The file id are given by iterating over Noir source folders, but the iteration may depend on the file system state.
To fix this, I simply enumerate files in file names order.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Copy link
Contributor

github-actions bot commented Dec 23, 2024

Peak Memory Sample

Program Peak Memory
keccak256 78.48M
workspace 123.76M
regression_4709 422.91M
ram_blowup_regression 1.58G
private-kernel-tail 201.61M
private-kernel-reset 716.87M
private-kernel-inner 291.68M
parity-root 171.93M

Copy link
Contributor

github-actions bot commented Dec 23, 2024

Execution Sample

Program Execution Time %
sha256_regression 0.618s 0%
regression_4709 0.397s 4%
ram_blowup_regression 4.434s 0%
rollup-base-public 21.410s 1%
rollup-base-private 19.358s -1%
private-kernel-tail 0.678s -4%
private-kernel-reset 1.457s -2%
private-kernel-inner 1.035s 5%
parity-root 0.529s -1%

Copy link
Contributor

github-actions bot commented Dec 23, 2024

Compilation Sample

Program Compilation Time %
sha256_regression 1.342s 1%
regression_4709 0.778s 0%
ram_blowup_regression 15.366s 1%
rollup-base-public 114.469s 2%
rollup-base-private 98.535s 0%
private-kernel-tail 1.058s 2%
private-kernel-reset 7.253s -1%
private-kernel-inner 2.371s 9%
parity-root 0.775s -2%
noir-contracts 86.293s 0%

@guipublic guipublic requested a review from TomAFrench December 23, 2024 16:54
@TomAFrench TomAFrench added this pull request to the merge queue Dec 23, 2024
Merged via the queue into master with commit baca790 Dec 23, 2024
85 checks passed
@TomAFrench TomAFrench deleted the gd/consistent_file_id branch December 23, 2024 17:13
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 24, 2024
…ked protocol circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 24, 2024
… circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 25, 2024
…ked protocol circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 25, 2024
… circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 26, 2024
…ked protocol circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 26, 2024
… circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 27, 2024
…ked protocol circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 27, 2024
… circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 28, 2024
…ked protocol circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 28, 2024
… circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 29, 2024
…ked protocol circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 29, 2024
… circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 30, 2024
…ked protocol circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 30, 2024
… circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 31, 2024
…ked protocol circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Dec 31, 2024
… circuits (noir-lang/noir#6903)

fix: consistent file_id across installation paths (noir-lang/noir#6912)
fix: bigint builtins are foreigns (noir-lang/noir#6892)
fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890)
chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622)
chore: Add `Instruction::Noop` (noir-lang/noir#6899)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants