-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: consistent file_id across installation paths #6912
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peak Memory Sample
|
Execution Sample
|
Compilation Sample
|
TomAFrench
approved these changes
Dec 23, 2024
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 24, 2024
…ked protocol circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 24, 2024
… circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 25, 2024
…ked protocol circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 25, 2024
… circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 26, 2024
…ked protocol circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 26, 2024
… circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 27, 2024
…ked protocol circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 27, 2024
… circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 28, 2024
…ked protocol circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 28, 2024
… circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 29, 2024
…ked protocol circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 29, 2024
… circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 30, 2024
…ked protocol circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 30, 2024
… circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 31, 2024
…ked protocol circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 31, 2024
… circuits (noir-lang/noir#6903) fix: consistent file_id across installation paths (noir-lang/noir#6912) fix: bigint builtins are foreigns (noir-lang/noir#6892) fix: remove unnecessary cast in bit-shift (noir-lang/noir#6890) chore: Release Noir(1.0.0-beta.1) (noir-lang/noir#6622) chore: Add `Instruction::Noop` (noir-lang/noir#6899)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves an issue where monomorphisation hash differ between compilations from different installation folders
Summary*
The file id are given by iterating over Noir source folders, but the iteration may depend on the file system state.
To fix this, I simply enumerate files in file names order.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.