Ensure compatibility with python-json-logger>=3.1.0 #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolar
force-pushed
the
jsonlogger
branch
2 times, most recently
from
fb38aef to
d69562c
Compare
Signed-off-by: Sergey Vasilyev <[email protected]>
|
Released as 1.37.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1146
closes #1148
The change introducing the issue:
As a reminder: the developers of the final apps (i.e. those going to docker images) SHOULD pin their dependencies with their package manager of choice (pip, poetry, whatnot) — as a generic "best practice" in the dev world (not Kopf- or K8s-specific).
Kopf deliberately does not pin its own runtime dependencies to leave freedom to app developers to resolve their version conflicts, except for
>=restrictions with minimally required functonality.Kopf also does not pin its CI dependencies — to see the failures caused by new releases of dependencies earlier — i.e. in nightly test runs (flaky now, even with proper dependencies; to be fixed "soon").