Replace dataclasses with attrs and slotted classes #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolar
force-pushed
the
dataclasses-to-attrs
branch
2 times, most recently
from
df3a655 to
71820f9
Compare
Signed-off-by: Sergey Vasilyev <[email protected]>
nolar
force-pushed
the
dataclasses-to-attrs
branch
from
71820f9 to
f21c018
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for further refactoring for proper time handling — so that this single change would be tested in all Python versions.
Besides, attrs produces the slotted classes by default, which is good for memory footprint, especially on the frequently used classes like
HandlerState,Outcome, etc.In all other aspects, it is essentially a drop-in replacement with some minor changes.
The
attrsdependency is already installed for one of the sub-dependencies, so nothing new is essentially added to the deployment.