Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for chat.completion to return sse response #2910

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

raja-jamwal
Copy link

Describe your changes

  • I was trying to use gpt4all with continue.dev but continue.dev expects SSE responses.
  • Added changes to return SSE response.
  • Tested with the publically available version of continue.dev and postman to validate the SSE response.

see this issue
#2174

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I have added thorough documentation for my code.
  • I have tagged PR with relevant project labels. I acknowledge that a PR without labels may be dismissed.
  • If this PR addresses a bug, I have provided both a screenshot/video of the original bug and the working solution.

Demo

Screenshot 2024-08-25 at 1 36 05 PM

Screenshot 2024-08-25 at 1 36 32 PM

Steps to Reproduce

  • install continue.dev, set it up to use the existing local gpt4all server. Ask him something, it blanks out.
  • Use this build to ask it something, and it'll respond.

Notes

@raja-jamwal raja-jamwal force-pushed the raja-support-sse-in-chat-response branch from 2bdaa9e to 05f125d Compare September 8, 2024 03:19
@raja-jamwal
Copy link
Author

raja-jamwal commented Sep 8, 2024

@cebtenzzre Can I get a review on this?

@manyoso manyoso requested a review from cebtenzzre September 10, 2024 14:56
@manyoso
Copy link
Collaborator

manyoso commented Sep 10, 2024

@cebtenzzre , please deal with this.

@lrq3000
Copy link

lrq3000 commented Nov 16, 2024

@cebtenzzre @manyoso Can someone please review this PR? It would be awesome to finally be able to use GPT4All in all OpenAI API compatible apps (eg, not just continuedev but also OpenInterpreter).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants