Fix Jinja2Cpp bug that broke system msg detection in templates #3325
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes system message detection in the chat template of models such as Mistral Instruct which handle it specially. The bug is not always easy to reproduce, but it seems to occur most reliably on Windows. The symptom is that when trying to chat with Mistral Instruct with a system prompt set, you get this instead of a response:
Details
The prompt template in question:
With Mistral Instruct, the Jinja2Cpp bug (see below) manifested as it missing the system prompt at
messages[0]
, but then finding it as the first message in the{%- for message in messages %}
loop, which caused it to call raise_exception as it was expecting it to be a user message instead.The Fix
From the commit I added to the submodule: