Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for binary PLY files #588

Merged
merged 10 commits into from
Dec 10, 2024
Merged

Add support for binary PLY files #588

merged 10 commits into from
Dec 10, 2024

Conversation

boxanm
Copy link
Collaborator

@boxanm boxanm commented Oct 14, 2024

Description

Summary:

This PR adds support for binary PLY files, both loading and exporting.
The main limitation is that libpointmatcher treats all possible data types as either floats or doubles.

Changes and type of changes (quick overview):

  • The implementation is far from optimal. We could eventually switch to an external dependency, such as those mentioned in this benchmark.
  • Problems may arise with type overflows when loading PLY files containing uint, int, or double fields since they might not fit into float. However, such files are relatively rare, and the current implementation suffices for most use cases, for example, the 3DMatch dataset.

Checklist:

Code related

  • I have made corresponding changes to the documentation
    (i.e.: function, class, script header, README.md)
  • I have commented hard-to-understand code
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
    (Check contributing_instructions.md for local testing procedure using libpointmatcher-build-system)

PR creation related

  • My pull request base ref branch is set to the develop branch
    (the build-system won't be triggered otherwise)
  • My pull request branch is up-to-date with the develop branch
    (the build-system will reject it otherwise)

PR description related

  • I have included a quick summary of the changes
  • I have indicated the related issue's id with # <issue-id> if changes are of type fix
  • I have included a high-level list of changes and their corresponding types
    (See commit_msg_reference.md for details)

Copy link

pointmatcher/IO.cpp Outdated Show resolved Hide resolved
@boxanm boxanm merged commit 8e180b2 into develop Dec 10, 2024
4 of 5 checks passed
@boxanm boxanm deleted the binary-ply-files branch December 10, 2024 14:23
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants