Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update npm dependencies #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

yuiseki
Copy link
Member

@yuiseki yuiseki commented Mar 9, 2023

npm依存関係が古すぎるので npm update を実行しました

動いてれば良い気がする

@yuiseki yuiseki self-assigned this Mar 9, 2023
@yuiseki yuiseki marked this pull request as ready for review March 9, 2023 05:05
@yuiseki yuiseki requested a review from benfoden March 9, 2023 05:20
Copy link
Member

@ohnishiakira ohnishiakira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

example/dest/sprite.svg の差分が見た目的に問題ないかだけ他の方にも見ていただきたいです。(自分の環境だと透明でよく分からず...)
npm run build:exampleするとこのSVGに変更が入るので、コミットしておくのは問題なさそうと思いました。

他の箇所はLGTMです!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants