Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StrikeHandler.java #461

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

damionx7
Copy link

@damionx7 damionx7 commented Oct 15, 2023

Add support for <strike> html tag.

README.md for Markwon library says that 3 html tags are supported for strikethrough "Strike-through (<s>, <strike>, <del>). But currently <strike> html tag does nothing. This patch tries to add support for <strike> html tag.

Add support for <strike> html tag.
@noties
Copy link
Owner

noties commented Oct 21, 2023

Hello @damionx7 ,

thanks for the contribution. I think this tag was not added because it is deprecated in favour of <s> and <del>. But we still can add it

@damionx7
Copy link
Author

Hello @damionx7 ,

thanks for the contribution. I think this tag was not added because it is deprecated in favour of <s> and <del>. But we still can add it

Thank you @noties. I can see that github checks for this pull request have failed. Is this normal ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants