Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 9.0.0, add plugin version 2 and 3, update tracer and tiny examples with register output. #16

Merged
merged 7 commits into from
Jun 3, 2024

Conversation

novafacing
Copy link
Owner

Should resolve #15. This PR adds support for new API versions 2 (for 9.0.0) and 3 (for >9.0.0) and their associated functionality. The demo plugins are also updated with register reading (the most exciting new feature).

@novafacing
Copy link
Owner Author

@tocklime if you have some time, maybe you can review this. I didn't have a chance to test on Windows, but everything looks good on Linux.

@novafacing
Copy link
Owner Author

A couple odds and ends not in here yet:

  • Update documentation about the plugin API version now being feature-flag-controlled (plugin-api-vX)
  • Add a convenience function for compiling a plugin thrice for each version? Maybe not necessary.

Copy link
Contributor

@tocklime tocklime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks. Have built it in msys. The tiny plugin works, and is giving me veeeeery verbose register output. Fun times. tracer doesn't compile on windows (use of UnixStream), but that's not new.

The plugin I'm writing internally compiles against this version fine (though I've not done the register stuff yet).

I spotted a couple of typos/dead code things.

qemu-plugin-sys/generate-bindings.rs Outdated Show resolved Hide resolved
qemu-plugin-sys/generate-bindings.rs Outdated Show resolved Hide resolved
qemu-plugin-sys/generate-bindings.rs Outdated Show resolved Hide resolved
@novafacing novafacing merged commit 7c481e8 into main Jun 3, 2024
4 checks passed
@novafacing novafacing deleted the add-v9.0.0-api branch June 3, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qemu plugins made with this don't work with Qemu 9.0.0 or later
2 participants