Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-service): remove skip ref #7357

Merged
merged 1 commit into from
Dec 23, 2024
Merged

feat(api-service): remove skip ref #7357

merged 1 commit into from
Dec 23, 2024

Conversation

djabarovgeorge
Copy link
Contributor

What changed? Why was the change needed?

do not reuse instances and by that remove the ref once zod parsed to json schema
image

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link
Contributor

@LetItRock LetItRock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! 🙌

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit ce9f953
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/67697706a125aa0008de46a7
😎 Deploy Preview https://deploy-preview-7357.dashboard.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 23, 2024

Deploy Preview for dashboard-v2-novu-staging ready!

Name Link
🔨 Latest commit ce9f953
🔍 Latest deploy log https://app.netlify.com/sites/dashboard-v2-novu-staging/deploys/67697706bc95a4000810e774
😎 Deploy Preview https://deploy-preview-7357.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@scopsy scopsy changed the title feat(api): remove skip ref feat(api-service): remove skip ref Dec 23, 2024
@scopsy scopsy merged commit c4c0b78 into next Dec 23, 2024
32 of 33 checks passed
@scopsy scopsy deleted the fix-remove-skip-ref branch December 23, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants