fix: npm pack marks the wrong files as executable #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reggi
reviewed
Oct 17, 2024
|
After reviewing the discussions and feedback it appears the root issue lies with npm pac incorrectly setting the chmod on the wrong file. While npm extract works as expected, the problem stems from the packing step which is outside the scope of this PR. This behavior needs further investigation to determine why npm pack modifying the chmod of the incorrect file. I am closing this PR since the underlying the issue is in the npm pack with chmod which is in place but currently broken. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an optional parameter to isPackageBin that allows for more flexible handling of the file path prefixes. By calling isPackageBin with replace = false in tar-create-options.js we avoid stripping the initial directory component (such as 'package/') from the file paths. This approach maintains existing functionality , pasess all the current tests, provides a clearer, more direct path-to-bin comparison without altering the established test suite behavior.
References
Related to [https://github.com/npm/cli/issues/7762]
Depends on #0
Blocked by #0
Fixes [https://github.com/npm/cli/issues/7762]
Closes [(https://github.com/npm/cli/issues/7762)]