This repository has been archived by the owner on Mar 26, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 30
Use NPR layout to format the post body in WordPress #74
Open
tamw-wnet
wants to merge
25
commits into
npr:master
Choose a base branch
from
wnet-ieg-2:assets_in_body
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…return a formatted body
…o javascript etc can be saved
…or video part of story
… SERIOUSLY improve import performance on multi-image posts
…on whether the admin selected to use the layout feature
Noting this would close #71 . Also noting that the build failure is due to Travis failing setting up WordPress at all -- see https://travis-ci.com/github/npr/nprapi-wordpress/jobs/368370017 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits at a settings toggle to optionally check for the existence of a 'layout' section in the NPR API response, and if present uses that layout to pull in order the corresponding paragraphs, images, externalAssets such as YouTube and Twitter oEmbeds, and HtmlAssets that are usually javascript or iframes. If one of the layout elements is a 'gallery' the primary image for the post is inserted in its place.
Leaving the toggle unchecked, or if no 'layout' section is found in the API response, leaves the previous handler for creating the post body unaltered.