Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wifi: Flash size optimizations #14415

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Conversation

krish2718
Copy link
Contributor

@krish2718 krish2718 commented Mar 6, 2024

Use separate patch file for System + Raw modes

@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Mar 6, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 6, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
nrfxlib nrfconnect/sdk-nrfxlib@9570844 nrfconnect/sdk-nrfxlib@2d90eef (main) nrfconnect/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@krish2718 krish2718 changed the title Separate raw patch wifi: Flash size optimizations Mar 7, 2024
@krish2718 krish2718 requested a review from ajayparida March 7, 2024 06:35
@ajayparida ajayparida requested a review from VivekUppunda March 7, 2024 12:43
@krish2718 krish2718 marked this pull request as ready for review March 18, 2024 08:25
@krish2718 krish2718 force-pushed the separate_raw_patch branch from 90bffbe to 83a0d29 Compare March 18, 2024 08:25
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 18, 2024

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-chip X
test-sdk-wifi X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

Pull in changes needed for separate raw modes patch.

Signed-off-by: Chaitanya Tata <[email protected]>
In order to save flash memory, move the support for Raw modes (TX
injection, monitor and promiscuous) to a separate image.

Implements SHEL-2580 which should fix SHEL-2579.

Signed-off-by: Chaitanya Tata <[email protected]>
Signed-off-by: Vivekananda Uppunda <[email protected]>
@krish2718 krish2718 requested a review from ioannisg March 19, 2024 13:43
@@ -52,9 +53,15 @@ config NRF700X_SCAN_ONLY
config NRF700X_RADIO_TEST
bool "Radio test mode of the nRF700x driver"

config NRF700X_SYSTEM_WITH_RAW_MODES
bool "Enable nRF700X system mode with raw modes"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krish2718 don't you need to select NET_L2_WIFI_MGMT here?


config NRF700X_PROMISC_DATA_RX
bool "Enable promiscuous RX sniffer operation in the driver"
select EXPERIMENTAL
depends on NRF700X_SYSTEM_MODE

config NRF700X_DATA_TX
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this is moved outside the if NRF700X_SYSTEM_MODE || NRF700X_SYSTEM_WITH_RAW_MODES

Copy link
Contributor

@ioannisg ioannisg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK with this patch to go in - it addresses a real problem.
That said, I would still like the Kconfig structure to be re-written, and become more general, so we can allow to extend easier in the future the number of patch variants. I can be done next time we add a new patch variant.

@rlubos rlubos merged commit 8e77d8e into nrfconnect:main Mar 19, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-nrfxlib
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants