-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wifi: Flash size optimizations #14415
Conversation
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
90bffbe
to
83a0d29
Compare
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
Pull in changes needed for separate raw modes patch. Signed-off-by: Chaitanya Tata <[email protected]>
In order to save flash memory, move the support for Raw modes (TX injection, monitor and promiscuous) to a separate image. Implements SHEL-2580 which should fix SHEL-2579. Signed-off-by: Chaitanya Tata <[email protected]> Signed-off-by: Vivekananda Uppunda <[email protected]>
83a0d29
to
c8463b2
Compare
@@ -52,9 +53,15 @@ config NRF700X_SCAN_ONLY | |||
config NRF700X_RADIO_TEST | |||
bool "Radio test mode of the nRF700x driver" | |||
|
|||
config NRF700X_SYSTEM_WITH_RAW_MODES | |||
bool "Enable nRF700X system mode with raw modes" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@krish2718 don't you need to select NET_L2_WIFI_MGMT here?
|
||
config NRF700X_PROMISC_DATA_RX | ||
bool "Enable promiscuous RX sniffer operation in the driver" | ||
select EXPERIMENTAL | ||
depends on NRF700X_SYSTEM_MODE | ||
|
||
config NRF700X_DATA_TX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason this is moved outside the if NRF700X_SYSTEM_MODE || NRF700X_SYSTEM_WITH_RAW_MODES
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am OK with this patch to go in - it addresses a real problem.
That said, I would still like the Kconfig structure to be re-written, and become more general, so we can allow to extend easier in the future the number of patch variants. I can be done next time we add a new patch variant.
Use separate patch file for System + Raw modes