Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test-spec: introduce specific ble-sample label #14552

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

guwa
Copy link
Contributor

@guwa guwa commented Mar 18, 2024

Add CI-ble-samples-test label and test spec for ble sample CI. It has different test scope than BLE CI

@guwa guwa requested a review from a team as a code owner March 18, 2024 13:46
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 18, 2024
@guwa
Copy link
Contributor Author

guwa commented Mar 18, 2024

Another PR in test-nrf has been created to link the new label with ble sample CI
https://projecttools.nordicsemi.no/bitbucket/projects/NCS-TEST/repos/test-fw-nrfconnect-nrf/pull-requests/806/diff#west.yml

@guwa guwa force-pushed the update_ble_sample_label branch from e2a290e to 234aa9d Compare March 18, 2024 13:51
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 18, 2024

Test specification

CI/Jenkins/NRF

  • Skipped

CI/Jenkins/integration

  • Skipped

Note: This message is automatically posted and updated by the CI

Copy link

@shanthanordic shanthanordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This label should also be introduced for test spec in nrfxlib and sdk-zephyr. @thst-nordic is there a guideline / internal doc how to add new labels ?

@guwa
Copy link
Contributor Author

guwa commented Mar 19, 2024

This label should also be introduced for test spec in nrfxlib and sdk-zephyr. @thst-nordic is there a guideline / internal doc how to add new labels ?

two PRs were created for zephyr and nrfxlib
nrfconnect/sdk-zephyr#1581
nrfconnect/sdk-nrfxlib#1266

Copy link

@shanthanordic shanthanordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Add CI-ble-samples-test label and test spec for ble sample CI.
It has different test scope than BLE CI

Signed-off-by: Guojun Wang <[email protected]>
@guwa guwa force-pushed the update_ble_sample_label branch from 234aa9d to f3a9131 Compare March 20, 2024 11:08
@nordicjm nordicjm merged commit 669806a into nrfconnect:main Mar 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants