nrf_wifi: Fix a buffer free issue for raw tx packet transmit done #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VivekUppunda
requested review from
krish2718,
sachinthegreen,
rado17 and
rlubos
as code owners
VivekUppunda
force-pushed
the
fix_buffer_free_issue
branch
from
6b40685 to
857773d
Compare
sachinthegreen
approved these changes
Feb 27, 2024
A recent fix to update statistics covered the txbuffer done process in an if-else check. This prevents tx buffers from being released on tx failure. place the status check to only update error statistics and remove txdone API from if check. Fixes SHEL-2448 for driver Signed-off-by: Vivekananda Uppunda <[email protected]>
VivekUppunda
force-pushed
the
fix_buffer_free_issue
branch
from
857773d to
9804eee
Compare
kapbh
approved these changes
Feb 27, 2024
krga2022
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent fix to update error statistics covered the txbuffer done process in an if-else check. This prevents tx buffers from being released on tx failure. place the status check to only update error statistics and remove txdone API from if check.