-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: update to nrf_oberon 3.0.15 #1317
Conversation
crypto/doc/CHANGELOG_oberon.rst
Outdated
Added | ||
===== | ||
|
||
* Added missing ocrypto functions for SECP160 curves which broke some configurations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The grammatical fix here depends on the intended meaning.
There should always be a comma after the word before which
, which in this case would read, "SECP160 curves, which broke some configurations."
However, I read this construction as meaning that adding the missing functions broke some configurations.
If this is not the intended meaning, use:
"SECP160 curves that broke..."
I read this as: missing functions broke some configurations, and adding them fixes it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was intended to write that the fact that we had the missing functions broke some configurations. Now that I added them back they should be fixed. So I updated the text based on your second suggestion.
@@ -38,7 +38,7 @@ extern "C" { | |||
int ocrypto_constant_time_equal(const void *x, const void *y, size_t length); | |||
|
|||
/** | |||
* Variable length compared to zero. | |||
* Variable length compare to zero. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comparison?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an external file that we get from Oberon so if this is not a blocker I would propose to leave it as is.
* Added missing ocrypto functions for SECP160 curves which broke some configurations. * Fixed a bug which resulted in AEAD encryption/decryptionwith AES-CCM producing incorrect results for large buffers (>1MB data with 12 byte nonce). Ref: NCSDK-26596 Signed-off-by: Georgios Vasilakis <[email protected]>
Remove the old version as it's own commmit. Signed-off-by: Georgios Vasilakis <[email protected]>
No description provided.