Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: update to nrf_oberon 3.0.15 #1317

Merged
merged 2 commits into from
May 15, 2024
Merged

Conversation

Vge0rge
Copy link
Contributor

@Vge0rge Vge0rge commented May 2, 2024

No description provided.

@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label May 2, 2024
@Vge0rge Vge0rge marked this pull request as ready for review May 8, 2024 07:24
@Vge0rge Vge0rge requested review from frkv and tejlmand as code owners May 8, 2024 07:24
@Vge0rge Vge0rge changed the title Only for CI: New Binaries for nrf_oberon crypto: update to nrf_oberon 3.0.15 May 8, 2024
@Vge0rge Vge0rge added this to the 2.7.0 milestone May 8, 2024
@Vge0rge Vge0rge requested review from mia-ko and melwee01 May 10, 2024 11:00
Added
=====

* Added missing ocrypto functions for SECP160 curves which broke some configurations.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The grammatical fix here depends on the intended meaning.

There should always be a comma after the word before which, which in this case would read, "SECP160 curves, which broke some configurations."

However, I read this construction as meaning that adding the missing functions broke some configurations.

If this is not the intended meaning, use:

"SECP160 curves that broke..."

I read this as: missing functions broke some configurations, and adding them fixes it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was intended to write that the fact that we had the missing functions broke some configurations. Now that I added them back they should be fixed. So I updated the text based on your second suggestion.

crypto/doc/CHANGELOG_oberon.rst Outdated Show resolved Hide resolved
@@ -38,7 +38,7 @@ extern "C" {
int ocrypto_constant_time_equal(const void *x, const void *y, size_t length);

/**
* Variable length compared to zero.
* Variable length compare to zero.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comparison?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an external file that we get from Oberon so if this is not a blocker I would propose to leave it as is.

Vge0rge added 2 commits May 14, 2024 12:54
* Added missing ocrypto functions for SECP160 curves which
  broke some configurations.
* Fixed a bug which resulted in AEAD encryption/decryptionwith
  AES-CCM producing incorrect results for large buffers
  (>1MB data with 12 byte nonce).

Ref: NCSDK-26596

Signed-off-by: Georgios Vasilakis <[email protected]>
Remove the old version as it's own commmit.

Signed-off-by: Georgios Vasilakis <[email protected]>
@nordicjm nordicjm merged commit 7bf4f9b into nrfconnect:main May 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants