nrf_rpc: remove NULL pointer referenece #1545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of error, the group pointer may be set to NULL. This reverts part of changes introduced in the following PR: nrfconnect#1493 Ref: NCSDK-29976 Signed-off-by: Tomasz Chyrowicz <[email protected]>
|
FYI @Damian-Nordic |
alxelax
approved these changes
Oct 29, 2024
ahasztag
requested changes
Oct 29, 2024
tomchy
force-pushed
the
bugfix/nrf_rpc/NCSDK-29976_Fix_null_dereference
branch
from
8bb9f82 to
9c841b2
Compare
Then it should be fixed correctly, not by reverting this commit. If changes are reverted, it breaks protocol serialization functionality. |
alxelax
requested changes
Oct 29, 2024
tomchy
force-pushed
the
bugfix/nrf_rpc/NCSDK-29976_Fix_null_dereference
branch
from
9c841b2 to
8bb9f82
Compare
Changed back to the partial revert. We are trying to fix the order of messages by adjusting the main thread priority. |
|
Alternate PR with fix: #1548 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts half of the changes introduced in the following PR:
#1493
Ref: NCSDK-29976