nrf_rpc: call bound_handler after init reply #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchy
reviewed
Oct 31, 2024
| * initialization from within the task to ensure that when this happens the init reply has | ||
| * already been sent and the remote is ready to receive nRF RPC commands. | ||
| */ | ||
| if (((*group)->bound_handler != NULL) || send_reply || signal_groups_init_event) { |
There was a problem hiding this comment.
Are you sure that this will not result in multiple bound_handler calls?
There was a problem hiding this comment.
I am not, but previously it was the same, right? I mean bound_handler was called for each incoming init packet, reglardless if this was the first or n-th packet.
alxelax
approved these changes
Oct 31, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@doki-nordic Could you review this PR? |
bpienk
approved these changes
Nov 18, 2024
1. Rename internal_data to internal_task to better describe the purpose of the structure. 2. Use internal_task_consumed event to notify about freeing the global task object for all types of tasks. 3. Use union for different types of tasks to not bloat the internal task structure when more tasks or fields are added. Signed-off-by: Damian Krolik <[email protected]>
1. Ensure that the group's bound_handler is called after sending the init reply. This is to make sure that the remote knows our group ID and is able to process incoming commands when the handler is called. 2. Similarly, signal groups_init_event after sending the init reply. Signed-off-by: Damian Krolik <[email protected]>
Damian-Nordic
force-pushed
the
nrf_rpc_init
branch
from
968be75 to
c3845fa
Compare
konradderda
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nrf_rpc: refactor internal tasks