[nrf noup] Migrate sample child image configuration to sysbuild #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-nordic
approved these changes
Oct 16, 2023
|
@alwa-nordic @asbjornsabo @hermabe @Thalley please review |
hermabe
reviewed
Oct 19, 2023
There was a problem hiding this comment.
I dont know exactly how sysbuild works, but the config for hci_rpmsg matches the existing one for the child_image so fine by me.
Some questions:
- Are you planning on removing the child_image configs and machinery? Now there seems to be two ways to build this sample.
- Why only this sample and not the others?
- Why in sdk-zephyr instead of upstream?
They will both co-exist for a period of time, then child/parent image support will be removed
These are the only child_image folders in sdk-zephyr
Child/parent is an ncs thing, the configurations copied here do not exist nor would they be used in zephyr. If they should be present in upstream zephyr, then that would be the fault of whomever added them to sdk-zephyr instead of submitting them to zephyr |
hermabe
approved these changes
Oct 19, 2023
cvinayak
requested review from
rlubos,
jukkar,
PavelVPV,
cvinayak,
kruithofa,
glarsennordic,
carlescufi,
carlocaione,
tejlmand,
nordic-krch,
ioannisg,
anangl,
jfischer-no,
aescolar,
koffes,
alexsven and
erikrobstad
as code owners
cvinayak
requested review from
rick1082,
gWacey,
lemrey and
a team
as code owners
Migrates child image configuration for this sample over to sysbuild Signed-off-by: Jamie McCrae <[email protected]>
Migrates child image configuration for this sample over to sysbuild Signed-off-by: Jamie McCrae <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.