Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream/presenter timing part segment remaining #1346

Draft
wants to merge 2 commits into
base: release52
Choose a base branch
from

Conversation

olzzon
Copy link
Contributor

@olzzon olzzon commented Dec 17, 2024

About the Contributor

This PR is made on behalf of BBC

Type of Contribution

This is a feature

Current Behavior

Currently the timers in presenter is using the that follows the NRK specs.

New Behavior

If CountdownType.SEGMENT_BUDGET_DURATION is set as countdownType the <CurrentPartOrSegmentRemaining/> component will be used instead of the <PieceCountdownContainer>
If not SEGMENT_BUDGET_DURATION the presenter functionality is not changed.

Testing

  • I have added one or more unit tests for this PR
  • I have updated the relevant unit tests
  • No unit test changes are needed for this PR

Affected areas

This affects only presenter screen and only if CountdownType.SEGMENT_BUDGET_DURATION is being used.

Time Frame

Other Information

The PR is awaiting approval from BBC.

Status

  • PR is ready to be reviewed.
  • The functionality has been tested by the author.
  • Relevant unit tests has been added / updated.
  • Relevant documentation (code comments, system documentation) has been added / updated.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.47%. Comparing base (83c11bf) to head (e217db1).
Report is 53 commits behind head on release52.

Additional details and impacted files
@@              Coverage Diff              @@
##           release52    #1346      +/-   ##
=============================================
+ Coverage      56.25%   56.47%   +0.21%     
=============================================
  Files            399      401       +2     
  Lines          71164    71925     +761     
  Branches        4495     4555      +60     
=============================================
+ Hits           40035    40617     +582     
- Misses         31028    31060      +32     
- Partials         101      248     +147     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Julusian Julusian added the Contribution from BBC Contributions sponsored by BBC (bbc.co.uk) label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution from BBC Contributions sponsored by BBC (bbc.co.uk)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants