Upstream/presenter timing part segment remaining #1346
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the Contributor
This PR is made on behalf of BBC
Type of Contribution
This is a feature
Current Behavior
Currently the timers in presenter is using the that follows the NRK specs.
New Behavior
If CountdownType.SEGMENT_BUDGET_DURATION is set as countdownType the
<CurrentPartOrSegmentRemaining/>
component will be used instead of the<PieceCountdownContainer>
If not SEGMENT_BUDGET_DURATION the presenter functionality is not changed.
Testing
Affected areas
This affects only presenter screen and only if CountdownType.SEGMENT_BUDGET_DURATION is being used.
Time Frame
Other Information
The PR is awaiting approval from BBC.
Status