-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added condition ENS ownership #564
Added condition ENS ownership #564
Conversation
Update `JsonApiConditionSchema` to match lingo
JSON path will always be able to be parsed. It only becomes invalid when combined with JSON, and this will only be known at decryption time.
This is a great start, thank you! I've got 2 comments :)
The condition is still defined exactly as you specified:
but behind the scenes it would create a contract condition that reads from the ens registry. This would fix both of my comments. @KPrasch thoughts? |
Please see this issue comment #104 (comment) for the context on ENS resolution. TLDR, it's a multi-step process that requires some development in |
965a5d7
to
c803e90
Compare
Type of PR:
Required reviews:
What this does:
Issues fixed/closed:
Why it's needed:
Notes for reviewers: