Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release nunit hotfix 4.3.1 #997

Merged
merged 3 commits into from
Dec 21, 2024
Merged

Release nunit hotfix 4.3.1 #997

merged 3 commits into from
Dec 21, 2024

Conversation

OsirisTerje
Copy link
Member

No description provided.

Copy link

github-actions bot commented Dec 20, 2024


A special thank you to the following reporters for identifying issues:

<table>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't have to hold up the PR at all, but I notice this is an HTML table rather than a markdown table. We should probably use markdown tables.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted it without header, since it is more of a 4 column list of names. Didnt find any markdown way to do that. But if have some tricks, please suggest :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes most sense as a bulleted list. Table probably shouldn't be used just to visually separate list items.

Copy link
Member

@SeanKilleen SeanKilleen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a minor suggestion and a comment.

@OsirisTerje OsirisTerje merged commit e029e0e into master Dec 21, 2024
7 checks passed
@OsirisTerje OsirisTerje deleted the release431 branch December 21, 2024 15:23
github-actions bot pushed a commit that referenced this pull request Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants