[T6A2][F11-B3]LEUNG Cheuk Ting #508
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xpdavid
reviewed
Mar 3, 2017
| @@ -0,0 +1,29 @@ | |||
| package seedu.addressbook.storage; | |||
There was a problem hiding this comment.
You also need to update the test case.
We are using stub here, which means in LogicTest we only care whether the logic works or not. We don't need to test the storage part anymore. (Yeah, there is somewhere in LogicTest that verifies whether the storage works or not. Find by yourself. :) )
|
|
||
|
|
||
| public AddressBook load() throws StorageOperationException{ | ||
| return this.addressBook; |
There was a problem hiding this comment.
Why do you need this code here? A return null is enough? Stubs don't usually do any work.
|
@ctleungac Some comments added. Please close the PR after reading comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.