[W5.11r][W15-B3] Pham Vu Hung #775
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldriclim
reviewed
Mar 11, 2018
|
|
||
| import seedu.addressbook.common.Messages; | ||
| import seedu.addressbook.data.exception.IllegalValueException; | ||
| import seedu.addressbook.data.person.*; |
| public CommandResult execute() { | ||
| try { | ||
| final ReadOnlyPerson target = getTargetPerson(); | ||
| toEdit.changeName(target.getName()); |
There was a problem hiding this comment.
There shouldn't be a random setter() just to cater for editting.
| ); | ||
| } | ||
|
|
||
| public ReadOnlyPerson getPerson() { |
| tagSet.add(new Tag(tagName)); | ||
| } | ||
| this.toEdit = new Person( | ||
| new Name("dummy"), |
There was a problem hiding this comment.
Could use the index to retrieve the name of toEdit.
| @@ -82,6 +82,19 @@ public void addPerson(Person toAdd) throws DuplicatePersonException { | |||
| allPersons.add(toAdd); | |||
| } | |||
|
|
|||
| public void editPerson(ReadOnlyPerson target, Person editedPerson) throws PersonNotFoundException { | |||
There was a problem hiding this comment.
Every public facing method should have a method header according to JavaDoc standards.
| * | ||
| * @param newName | ||
| */ | ||
| public void changeName(Name newName) { |
okkhoy
reviewed
Mar 12, 2018
| } | ||
|
|
||
| @Test | ||
| public void execute_edit_invalidArgsFormat() throws Exception { |
There was a problem hiding this comment.
your test names do not follow the convention specified in our coding guidelines.
please take note and name them appropriately in your project
|
@LeonidAgarth |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 2 enhancements: SortCommand and EditCommand
I sincerely apologize for submitting late