-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CS2103T-F12-3] Tagline #111
Open
stevenwjy
wants to merge
131
commits into
nus-cs2103-AY1920S1:master
Choose a base branch
from
AY1920S1-CS2103T-F12-3:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[CS2103T-F12-3] Tagline #111
stevenwjy
wants to merge
131
commits into
nus-cs2103-AY1920S1:master
from
AY1920S1-CS2103T-F12-3:master
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update AboutUs.adoc for team members to commit (#2)
Adds About Us for Yehezkiel
Merge with main repository
Update mainClassName in build.gradle
something about seedu changed to tagline
[Jonas] update AboutUs team member details
* Added Contact Command + Basic Commands to UserGuide.adoc
* Update AboutUs.adoc for team members to commit * Add more use cases to Developer Guide * Update team name
* Adds note create command to UG * Updates UG Format Consistency * Adds note delete command to UG * Adds note edit command * Adds command for not tagging * Add filter notes command
* Renames yehezkiel.png to Yehezkiel01.png * Adds steven about us page
* Add changes from team repo (#5) * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Merge pull request #6 from from AY1920S1-CS2103T-F12-3/master * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Added Contact Command + Basic Commands to UserGuide.adoc * Update mentions of AddressBook to TagLine * Update AboutUs.adoc * Add more use cases to Developer Guide * Update team name * Update UG: group command
#20 * Removed 'Learning Outcomes' in README * Acknowledge SE-EDU in README * Update 'About TagLine' in README * Fix merge conflict in UserGuide.adoc
Fixes #21
* Add changes from team repo (#5) * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Merge pull request #6 from from AY1920S1-CS2103T-F12-3/master * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Added Contact Command + Basic Commands to UserGuide.adoc * Update mentions of AddressBook to TagLine * Update AboutUs.adoc * Add more use cases to Developer Guide * Update team name * Add newline after EOF for README and AboutUs * Fix Yehez image name * Merge PR #10 from AY1920S1-CS2103T-F12-3/main * Update Prof name in AboutUs (#35) #21 * Rename Yehezkiel image (#36) * Fix typos in Developer Guide and User Guide (#37) * Updates from upstream (#14) * Add chat pane to GUI (#9) * Refactor result pane view (#42) * Implement view switching in GUI (#46) * Refactor Contact Command Parsers (#43) * Update contact parser (#62) * Rename person to contact (#65) * Fix merge conflicts from upstream * Fix merge conflicts * Add missing files to master from upstream * Remove dummy view * Merge updates from AY1920S1-CS2103T-F12-3/main (#18) Add DeleteNoteCommandTest * Updates from upstream (#19) * Refactor TagList to UniqueTagList and TagBook to follow structure Full changelist: - Refactor TagList to UniqueTagList - Add TagBook to implement ReadOnlyTagBook - Change storage to use ReadOnlyTagBook instead of TagList - Include new definition of equality for Tags (all fields equal except ID) - Standardize UniqueXXXXList method naming convention * Update architecture diagrams, UI structure, user stories, use cases and NFRs (#108) * Fix NoteBook.java for duplicate findNote() * Updates from upstream (#21) * Update Dev Guide Proposed Component (#123) * DG changes in diagram to update future proposed implementation * clearer docs * added linebreaks * line breaks * linebreak * formatting * Refactor ResultPane into a separate class (#103) * Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Add some tests and remove ContactCard index * Add new test to NoteListCardTest * Remove magic literal in NoteListCard * Fix variable declaration order * Refactor ResultPane into a separate class * Add missing Javadoc * Add note filtering implementation to DG (#124) * Merge updates from AY1920S1-CS2103T-F12-3/main Tests for delete note Tests for edit note XML for DG Group feature * Add detailed example for note create, delete, edit in UG * Add detail example for note list, clear in UG * Set image width to 600 * Add images for UG * Fix some bugs in UG * Add comment on deleted note id
* Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Update prompting feature description in DG * Update prompting section in DG * Update Ui section in DG * Add endlines * Un-compress xml files
* Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Update prompting feature description in DG * Update prompting section in DG * Update Ui section in DG * Add endlines * Un-compress xml files * Fix minor typo * Add PPP for tanlk99 * Expand D**G
* Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Update prompting feature description in DG * Update prompting section in DG * Update Ui section in DG * Add endlines * Un-compress xml files * Fix minor typo * Add PPP for tanlk99 * Expand D**G * Fix missing endline
* Add changes from team repo (#5) * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Merge pull request #6 from from AY1920S1-CS2103T-F12-3/master * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Added Contact Command + Basic Commands to UserGuide.adoc * Update mentions of AddressBook to TagLine * Update AboutUs.adoc * Add more use cases to Developer Guide * Update team name * Add newline after EOF for README and AboutUs * Fix Yehez image name * Merge PR #10 from AY1920S1-CS2103T-F12-3/main * Update Prof name in AboutUs (#35) #21 * Rename Yehezkiel image (#36) * Fix typos in Developer Guide and User Guide (#37) * Updates from upstream (#14) * Add chat pane to GUI (#9) * Refactor result pane view (#42) * Implement view switching in GUI (#46) * Refactor Contact Command Parsers (#43) * Update contact parser (#62) * Rename person to contact (#65) * Fix merge conflicts from upstream * Fix merge conflicts * Add missing files to master from upstream * Remove dummy view * Merge updates from AY1920S1-CS2103T-F12-3/main (#18) Add DeleteNoteCommandTest * Updates from upstream (#19) * Refactor TagList to UniqueTagList and TagBook to follow structure Full changelist: - Refactor TagList to UniqueTagList - Add TagBook to implement ReadOnlyTagBook - Change storage to use ReadOnlyTagBook instead of TagList - Include new definition of equality for Tags (all fields equal except ID) - Standardize UniqueXXXXList method naming convention * Update architecture diagrams, UI structure, user stories, use cases and NFRs (#108) * Fix NoteBook.java for duplicate findNote() * Updates from upstream (#21) * Update Dev Guide Proposed Component (#123) * DG changes in diagram to update future proposed implementation * clearer docs * added linebreaks * line breaks * linebreak * formatting * Refactor ResultPane into a separate class (#103) * Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Add some tests and remove ContactCard index * Add new test to NoteListCardTest * Remove magic literal in NoteListCard * Fix variable declaration order * Refactor ResultPane into a separate class * Add missing Javadoc * Add note filtering implementation to DG (#124) * Merge updates from AY1920S1-CS2103T-F12-3/main Tests for delete note Tests for edit note XML for DG Group feature * Add detailed example for note create, delete, edit in UG * Add detail example for note list, clear in UG * Set image width to 600 * Add images for UG * Fix some bugs in UG * Add comment on deleted note id * Update note filter in DG * Show all notes after deleting * Fix test error * Fix test error * Fix checkstyle
* Add changes from team repo (#5) * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Merge pull request #6 from from AY1920S1-CS2103T-F12-3/master * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Added Contact Command + Basic Commands to UserGuide.adoc * Update mentions of AddressBook to TagLine * Update AboutUs.adoc * Add more use cases to Developer Guide * Update team name * Add newline after EOF for README and AboutUs * Fix Yehez image name * Merge PR #10 from AY1920S1-CS2103T-F12-3/main * Update Prof name in AboutUs (#35) #21 * Rename Yehezkiel image (#36) * Fix typos in Developer Guide and User Guide (#37) * Updates from upstream (#14) * Add chat pane to GUI (#9) * Refactor result pane view (#42) * Implement view switching in GUI (#46) * Refactor Contact Command Parsers (#43) * Update contact parser (#62) * Rename person to contact (#65) * Fix merge conflicts from upstream * Fix merge conflicts * Add missing files to master from upstream * Remove dummy view * Merge updates from AY1920S1-CS2103T-F12-3/main (#18) Add DeleteNoteCommandTest * Updates from upstream (#19) * Refactor TagList to UniqueTagList and TagBook to follow structure Full changelist: - Refactor TagList to UniqueTagList - Add TagBook to implement ReadOnlyTagBook - Change storage to use ReadOnlyTagBook instead of TagList - Include new definition of equality for Tags (all fields equal except ID) - Standardize UniqueXXXXList method naming convention * Update architecture diagrams, UI structure, user stories, use cases and NFRs (#108) * Fix NoteBook.java for duplicate findNote() * Updates from upstream (#21) * Update Dev Guide Proposed Component (#123) * DG changes in diagram to update future proposed implementation * clearer docs * added linebreaks * line breaks * linebreak * formatting * Refactor ResultPane into a separate class (#103) * Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Add some tests and remove ContactCard index * Add new test to NoteListCardTest * Remove magic literal in NoteListCard * Fix variable declaration order * Refactor ResultPane into a separate class * Add missing Javadoc * Add note filtering implementation to DG (#124) * Merge updates from AY1920S1-CS2103T-F12-3/main Tests for delete note Tests for edit note XML for DG Group feature * Add detailed example for note create, delete, edit in UG * Add detail example for note list, clear in UG * Set image width to 600 * Add images for UG * Fix some bugs in UG * Add comment on deleted note id * Update note filter in DG * Show all notes after deleting * Fix test error * Fix test error * Fix checkstyle * Add PPP
* Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Refactor parsers and add new tests - Also fixes prefix for groups
* Add changes from team repo (#5) * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Merge pull request #6 from from AY1920S1-CS2103T-F12-3/master * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Added Contact Command + Basic Commands to UserGuide.adoc * Update mentions of AddressBook to TagLine * Update AboutUs.adoc * Add more use cases to Developer Guide * Update team name * Add newline after EOF for README and AboutUs * Fix Yehez image name * Merge PR #10 from AY1920S1-CS2103T-F12-3/main * Update Prof name in AboutUs (#35) #21 * Rename Yehezkiel image (#36) * Fix typos in Developer Guide and User Guide (#37) * Updates from upstream (#14) * Add chat pane to GUI (#9) * Refactor result pane view (#42) * Implement view switching in GUI (#46) * Refactor Contact Command Parsers (#43) * Update contact parser (#62) * Rename person to contact (#65) * Fix merge conflicts from upstream * Fix merge conflicts * Add missing files to master from upstream * Remove dummy view * Merge updates from AY1920S1-CS2103T-F12-3/main (#18) Add DeleteNoteCommandTest * Updates from upstream (#19) * Refactor TagList to UniqueTagList and TagBook to follow structure Full changelist: - Refactor TagList to UniqueTagList - Add TagBook to implement ReadOnlyTagBook - Change storage to use ReadOnlyTagBook instead of TagList - Include new definition of equality for Tags (all fields equal except ID) - Standardize UniqueXXXXList method naming convention * Update architecture diagrams, UI structure, user stories, use cases and NFRs (#108) * Fix NoteBook.java for duplicate findNote() * Updates from upstream (#21) * Update Dev Guide Proposed Component (#123) * DG changes in diagram to update future proposed implementation * clearer docs * added linebreaks * line breaks * linebreak * formatting * Refactor ResultPane into a separate class (#103) * Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Add some tests and remove ContactCard index * Add new test to NoteListCardTest * Remove magic literal in NoteListCard * Fix variable declaration order * Refactor ResultPane into a separate class * Add missing Javadoc * Add note filtering implementation to DG (#124) * Merge updates from AY1920S1-CS2103T-F12-3/main Tests for delete note Tests for edit note XML for DG Group feature * Add detailed example for note create, delete, edit in UG * Add detail example for note list, clear in UG * Set image width to 600 * Add images for UG * Fix some bugs in UG * Add comment on deleted note id * Update note filter in DG * Show all notes after deleting * Fix test error * Fix test error * Fix checkstyle * Add PPP * Fix PPP * Udate PPP * Fix link in PPP
* Update AboutUs link
* Add checker for existence of group name * Add a function to check whether a tag is considered valid in a model
* Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Update AboutUs link * Shorten PPP to fit page limit * Undo commit * Compress images slightly * Fix typo
* Fix contact list in UG * Update contact create with the same name * Fix error message
* Update contact show to also include notes with associated group * Rename method
* Validation for existence in contact tag and group tag * Reject untagging untagged tag
* Add save tagbook to logic * Fix bug saving group tag for notes
* sampledata * dev guide * UG fix * ppp, dg changes * ppp * PPP * checkstyle * UG changes
* Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Fix typo * Partially fix sync issue (Tag List is still bugged) * Fix sync issue * Update to show all notes after tag/untag * Fix trailing whitespace * Fix broken link * Remove full diagram from PPP * Update PPP pdf
* Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Fix typo * Change autocomplete behavior slightly, and include manual testing instructions
* ppp * instructions for manual testing * dg
* Update UG for note tag command * Add more description for note untag * Removes isSameContact * Updates UserGuide * Justify test
* Add changes from team repo (#5) * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Merge pull request #6 from from AY1920S1-CS2103T-F12-3/master * Refactor package name from 'seedu.address' to 'tagline' * Update mainClassName in build.gradle * Added Contact Command + Basic Commands to UserGuide.adoc * Update mentions of AddressBook to TagLine * Update AboutUs.adoc * Add more use cases to Developer Guide * Update team name * Add newline after EOF for README and AboutUs * Fix Yehez image name * Merge PR #10 from AY1920S1-CS2103T-F12-3/main * Update Prof name in AboutUs (#35) #21 * Rename Yehezkiel image (#36) * Fix typos in Developer Guide and User Guide (#37) * Updates from upstream (#14) * Add chat pane to GUI (#9) * Refactor result pane view (#42) * Implement view switching in GUI (#46) * Refactor Contact Command Parsers (#43) * Update contact parser (#62) * Rename person to contact (#65) * Fix merge conflicts from upstream * Fix merge conflicts * Add missing files to master from upstream * Remove dummy view * Merge updates from AY1920S1-CS2103T-F12-3/main (#18) Add DeleteNoteCommandTest * Updates from upstream (#19) * Refactor TagList to UniqueTagList and TagBook to follow structure Full changelist: - Refactor TagList to UniqueTagList - Add TagBook to implement ReadOnlyTagBook - Change storage to use ReadOnlyTagBook instead of TagList - Include new definition of equality for Tags (all fields equal except ID) - Standardize UniqueXXXXList method naming convention * Update architecture diagrams, UI structure, user stories, use cases and NFRs (#108) * Fix NoteBook.java for duplicate findNote() * Updates from upstream (#21) * Update Dev Guide Proposed Component (#123) * DG changes in diagram to update future proposed implementation * clearer docs * added linebreaks * line breaks * linebreak * formatting * Refactor ResultPane into a separate class (#103) * Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Add some tests and remove ContactCard index * Add new test to NoteListCardTest * Remove magic literal in NoteListCard * Fix variable declaration order * Refactor ResultPane into a separate class * Add missing Javadoc * Add note filtering implementation to DG (#124) * Merge updates from AY1920S1-CS2103T-F12-3/main Tests for delete note Tests for edit note XML for DG Group feature * Add detailed example for note create, delete, edit in UG * Add detail example for note list, clear in UG * Set image width to 600 * Add images for UG * Fix some bugs in UG * Add comment on deleted note id * Update note filter in DG * Show all notes after deleting * Fix test error * Fix test error * Fix checkstyle * Add PPP * Fix PPP * Udate PPP * Fix link in PPP * Add legend to PPP * Add manual tests for notes
* Update creating tag note command diagram * Change a text in diagram * Move CreateOrFindTag to TagManager * Update DG for Executing tag note command * Add Manual Testing section for tagging a note
* Update creating tag note command diagram * Change a text in diagram * Move CreateOrFindTag to TagManager * Update DG for Executing tag note command * Add Manual Testing section for tagging a note * Add a template for my PPP * Add more SampleDataUtil for Group Tag * Add authorship on contact command, tag command and hash tag model * Add HashTag Test * Add Hash Tag Test * PPP * Add yehezkiel01.pdf * Update pdf * Update link
* Update AboutUs.adoc for team members to commit * Add a newline in AboutUs.adoc * Add more use cases to Developer Guide * Fix missing endline * Update various docs to display TagLine * Add placeholder image * Fix minor typo in user guide * Update Tagline to TagLine * Update team name * Fix some typos in user guide and developer guide * Fix typo * Update app version * Update log file name * Fix tag note prompt bug * Fix error in exception * Fix checkstyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.