[CS2103T-F13-4] Ezwatchlist #202
Conversation
|
|
||
| By: `Team SE-EDU` Since: `Jun 2016` Licence: `MIT` | ||
| By: `Team CS2103T-F13-4` Since: `Sept 2019` Licence: `NUS` | ||
|
|
||
| == Setting up | ||
|
|
There was a problem hiding this comment.
Line 34 - the link "diagrams" does not work for your file. However, the original link works for the original addressBook3. Create a section "diagrams" in docs so that the link will work, with every diagram in the .puml form
|
|
||
| By: `Team SE-EDU` Since: `Jun 2016` Licence: `MIT` | ||
| By: `Team CS2103T-F13-4` Since: `Sept 2019` Licence: `NUS` | ||
|
|
||
| == Setting up | ||
|
|
There was a problem hiding this comment.
It seems like most of your URL diagrams are rather similar to the ones already given (except for occasional change in names). If you haven't updated your UML diagrams, please do so.
|
|
||
| By: `Team SE-EDU` Since: `Jun 2016` Licence: `MIT` | ||
| By: `Team CS2103T-F13-4` Since: `Sept 2019` Licence: `NUS` | ||
|
|
||
| == Setting up |
| @@ -295,71 +529,269 @@ Priorities: High (must have) - `* * \*`, Medium (nice to have) - `* \*`, Low (un | |||
| [width="59%",cols="22%,<23%,<25%,<30%",options="header",] | |||
| |======================================================================= | |||
| |Priority |As a ... |I want to ... |So that I can... | |||
There was a problem hiding this comment.
User stories are generally very comprehensive and elaborate, well done!
docs/DeveloperGuide.adoc
Outdated
|
|
||
| The following activity diagram summarises the workflow of Search: | ||
|
|
||
| image::SearchActivityDiagram.png[] |
There was a problem hiding this comment.
Dude image is too large you should try to make it smaller
docs/DeveloperGuide.adoc
Outdated
| ** Pros: Less calculation needed. | ||
| ** Cons: Appear less responsive. | ||
| // end::statistics[] | ||
|
|
||
| // tag::undoredo[] | ||
| === [Proposed] Undo/Redo feature |
There was a problem hiding this comment.
The diagrams / sentences from this section seems like a wholesale copy from the original ab3. Perhaps you would like to consider altering some of the diagrams / functions / sentences such that it is more catered to your project
|
|
||
| The following sequence diagram shows how the watch operation works: | ||
|
|
||
| image::WatchSequenceDiagram.png[] |
There was a problem hiding this comment.
after the cross, there should not be anymore dashed line, even though we are aware of the technical difficulties in implementing such.
…e command in search and statistics tabs
… into fridaynight # Conflicts: # src/test/java/seedu/ezwatchlist/logic/commands/CommandResultTest.java
Added coverage test
Fixed potential bug in recommendations.
Added user guide.
Fixed bug in user guide watch command
Added more WatchCommand tests
Update PPP
… into testcoverage13
updated PPP User guide dev guide
Added manual testing cases in the dev guide
Revert "Update PPP"
Edited one line of code
…-280-master Revert "Revert "Update PPP""
No description provided.