Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2711: Show that upload is still alive for very large files #4227

Conversation

swetayadav1
Copy link
Contributor

No description provided.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ gitofanindya
❌ swetayadav1


swetayadav1 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ gitofanindya
❌ swetayadav1


swetayadav1 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fa10b5a) 47.30% compared to head (c21d4f1) 47.79%.
Report is 27 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4227      +/-   ##
==========================================
+ Coverage   47.30%   47.79%   +0.49%     
==========================================
  Files          93       94       +1     
  Lines       15645    15677      +32     
==========================================
+ Hits         7401     7493      +92     
+ Misses       8244     8184      -60     
Flag Coverage Δ
functional 36.74% <53.48%> (-1.13%) ⬇️
integration 2.06% <34.88%> (?)
unit 37.41% <100.00%> (+1.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
nxdrive/client/uploader/__init__.py 30.35% <100.00%> (+10.08%) ⬆️
nxdrive/dao/engine.py 62.24% <100.00%> (+1.13%) ⬆️
nxdrive/engine/activity.py 97.82% <100.00%> (+0.15%) ⬆️
nxdrive/gui/view.py 39.20% <100.00%> (+2.97%) ⬆️
nxdrive/logging_config.py 87.34% <100.00%> (+0.89%) ⬆️
nxdrive/logging_filter_patterns.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swetayadav1 swetayadav1 requested review from gitofanindya, mr-shekhar and poojadaine and removed request for gitofanindya October 18, 2023 13:31
Copy link
Collaborator

@mr-shekhar mr-shekhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@swetayadav1 swetayadav1 merged commit eafde22 into master Nov 2, 2023
21 checks passed
@swetayadav1 swetayadav1 deleted the wip-NXDRIVE-2711-Show-that-upload-is-still-alive-for-very-large-files branch November 2, 2023 13:45
gitofanindya pushed a commit that referenced this pull request Mar 15, 2024
…4227)

NXDRIVE-2711: Show thta upload is still alive for very large file

Co-authored-by: swetayadav1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants