Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2929: Upgrade Python from 3.9.5 to 3.12.3. #5197

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

poojadaine
Copy link
Contributor

No description provided.

Copy link
Contributor

sourcery-ai bot commented Aug 28, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.57%. Comparing base (e57e0ab) to head (620f79a).

Files with missing lines Patch % Lines
nxdrive/engine/engine.py 50.00% 1 Missing ⚠️
nxdrive/engine/watcher/remote_watcher.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5197      +/-   ##
==========================================
- Coverage   52.09%   50.57%   -1.52%     
==========================================
  Files          96       96              
  Lines       16094    16116      +22     
==========================================
- Hits         8384     8151     -233     
- Misses       7710     7965     +255     
Flag Coverage Δ
functional 42.84% <66.66%> (-0.04%) ⬇️
integration 2.01% <0.00%> (-0.01%) ⬇️
unit 38.64% <77.77%> (-1.88%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mr-shekhar
Copy link
Collaborator

@dependabot rebase

@mr-shekhar
Copy link
Collaborator

@dependabot rebase master

@CLAassistant
Copy link

CLAassistant commented Jan 6, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ poojadaine
✅ gitofanindya
❌ unknown


unknown seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ gitofanindya
✅ poojadaine
❌ unknown


unknown seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants