NXDRIVE-2980: Implement GitHub runner for macos intel based architecture

[gitofanindya]

Summary by Sourcery

Update the CI workflow to target macOS 13 for GitHub Actions and adjust the macOS deployment script by removing certain filesystem arguments. Additionally, update the hash for PyQt5-Qt5 in the requirements for Darwin systems.

Build:

• Modify the macOS deployment script to remove specific filesystem arguments when creating a package.

CI:

• Update GitHub Actions workflow to use macOS 13 for CI builds instead of the latest macOS version.

[sourcery-ai]

Reviewer's Guide by Sourcery

This PR updates the GitHub Actions workflow to use a specific macOS runner (macos-13) instead of macos-latest, and makes related changes to the macOS deployment configuration. The changes also include updates to PyQt5-Qt5 hash for Darwin systems and simplification of DMG creation parameters.

Class diagram for DMG creation script changes

classDiagram
    class DeployCIAgent {
        -srcfolder : String
        -volname : String
        -format : String
        -size : String
        +create_package()
    }
    note for DeployCIAgent "Removed HFS+ and fsargs options from DMG creation"

Loading

File-Level Changes

Change	Details	Files
Updated GitHub Actions workflow to use a specific macOS runner version	Changed runner from 'macos-latest' to 'macos-13' Updated all conditional statements in the workflow to match the new runner name	.github/workflows/release.yml
Updated PyQt5-Qt5 package hash for Darwin systems	Changed the hash value for PyQt5-Qt5 version 5.15.13 on Darwin platform	tools/deps/requirements.txt
Simplified DMG creation parameters in macOS deployment script	Removed filesystem type specification (HFS+) Removed filesystem arguments for block size configuration	tools/osx/deploy_ci_agent.sh

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @gitofanindya - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please explain why the HFS+ filesystem specification and allocation parameters were removed from the DMG creation. This could impact compatibility and performance - was this intentional?

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.09%. Comparing base (74fc14e) to head (6f4ba42).
Report is 43 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5484      +/-   ##
==========================================
+ Coverage   49.24%   52.09%   +2.84%     
==========================================
  Files          94       96       +2     
  Lines       15699    16094     +395     
==========================================
+ Hits         7731     8384     +653     
+ Misses       7968     7710     -258     

Flag	Coverage Δ
functional	42.87% <ø> (+4.80%)	⬆️
integration	2.01% <ø> (-0.06%)	⬇️
unit	40.51% <ø> (+2.94%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.