Fixes for running on mesa #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kurt Kartaltepe <[email protected]>
|
Thank you, Kurt - we'll look at your proposed change very soon. |
zlatinski
reviewed
May 20, 2023
| @@ -304,9 +304,9 @@ void Shell::AcquireBackBuffer(bool trainFrame) { | |||
| // acquire just once when not presenting | |||
| if (m_settings.noPresent && GetCurrentBackBuffer().GetAcquireSemaphore() != VK_NULL_HANDLE) return; | |||
|
|
|||
| AcquireBuffer* acquireBuf = m_ctx.acquireBuffers.front(); | |||
| assert(!m_ctx.acquireBuffers.empty()); | |||
There was a problem hiding this comment.
I don't understand why do we need this change?
The rest of the changes make sense and I'll push alternative changes for those.
There was a problem hiding this comment.
assert(acquireBuf != nullptr); depends on front() returning a nullptr when empty, but this is undefined behavior and in practice it does not return a nullptr with libstdc++.
This replaces that assert with an assert that acquireBuffers is !empty()
The diff maybe looks a bit odd since the assert is moved before the front() call.
|
I have already applied these changes in a different form. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes from #41 for correctness issues.
You can also see the other changes required to run on mesa in https://github.com/kkartaltepe/vk_video_samples/tree/minimal-runnable that cover the other issues mentioned. But note minimal branch does not render correctly, as the dpb workaround is not correct.