Removing store param check.

o19s · Mar 11, 2024 · a9165f4 · a9165f4
1 parent 3b4e43a
commit a9165f4
Showing 1 changed file with 17 additions and 29 deletions.
diff --git a/src/main/java/com/o19s/ubi/rest/UserBehaviorInsightsRestHandler.java b/src/main/java/com/o19s/ubi/rest/UserBehaviorInsightsRestHandler.java
@@ -209,45 +209,33 @@ private RestChannelConsumer create(final NodeClient nodeClient, final String sto
 
     private RestChannelConsumer post(final NodeClient nodeClient, final String storeName, final RestRequest restRequest) throws IOException {
 
-        if(storeName == null || storeName.isEmpty()) {
+        try {
 
-            final XContentBuilder builder = XContentType.JSON.contentBuilder();
-            builder.startObject().field("error", "a store name is required");
-            builder.endObject();
-
-            return (channel) -> channel.sendResponse(new BytesRestResponse(RestStatus.BAD_REQUEST, builder));
-
-        } else {
+            final String eventJson = restRequest.content().utf8ToString();
+            final String eventJsonWithTimestamp = setEventTimestamp(eventJson);
 
-            try {
+            LOGGER.info("Indexing UBI event into store {}", storeName);
+            final String eventsIndexName = UbiUtils.getEventsIndexName(storeName);
 
-                final String eventJson = restRequest.content().utf8ToString();
-                final String eventJsonWithTimestamp = setEventTimestamp(eventJson);
+            final Event event = new Event(eventsIndexName, eventJsonWithTimestamp);
+            OpenSearchEventManager.getInstance(nodeClient).add(event);
 
-                LOGGER.info("Indexing UBI event into store {}", storeName);
-                final String eventsIndexName = UbiUtils.getEventsIndexName(storeName);
-
-                final Event event = new Event(eventsIndexName, eventJsonWithTimestamp);
-                OpenSearchEventManager.getInstance(nodeClient).add(event);
-
-            } catch (JsonProcessingException ex) {
-                LOGGER.error("Unable to get/set timestamp on UBI event.", ex);
-
-                final XContentBuilder builder = XContentType.JSON.contentBuilder();
-                builder.startObject().field("error", "unable to set event timestamp");
-                builder.endObject();
-
-                return (channel) -> channel.sendResponse(new BytesRestResponse(RestStatus.BAD_REQUEST, builder));
-            }
+        } catch (JsonProcessingException ex) {
+            LOGGER.error("Unable to get/set timestamp on UBI event.", ex);
 
             final XContentBuilder builder = XContentType.JSON.contentBuilder();
-            builder.startObject().field("status", "received");
+            builder.startObject().field("error", "unable to set event timestamp");
             builder.endObject();
 
-            return (channel) -> channel.sendResponse(new BytesRestResponse(RestStatus.OK, builder));
-
+            return (channel) -> channel.sendResponse(new BytesRestResponse(RestStatus.BAD_REQUEST, builder));
         }
 
+        final XContentBuilder builder = XContentType.JSON.contentBuilder();
+        builder.startObject().field("status", "received");
+        builder.endObject();
+
+        return (channel) -> channel.sendResponse(new BytesRestResponse(RestStatus.OK, builder));
+
     }
 
     private RestChannelConsumer delete(final NodeClient nodeClient, final String storeName) throws IOException {