chore: revert incorrect changes to Makefile #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
changed the title
Pull Request Test Coverage Report for Build 4412Details
💛 - Coveralls |
rgrinberg
force-pushed
the
ps/rr/chore__revert_incorrect_chagnes_to_makefile
branch
from
6c6d9ea to
d1ea8f6
Compare
<!-- ps-id: 54624f06-bdbf-43b3-a62d-56b3dbe5c01a -->
|
Thanks a lot for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@xvw your original is still flaky even with your workaround. Your workaround also makes the tests way slower for everyone. Let's keep the test suite in a healthy state.