Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] goblint-cil (2.0.4) #26307

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Conversation

sim642
Copy link
Contributor

@sim642 sim642 commented Jul 30, 2024

sim642 added 2 commits July 30, 2024 13:32
CHANGES:

* Add `Return` statement expression location (goblint/cil#167).
* Add `availability` attribute support (goblint/cil#168, goblint/cil#171).
* Remove unused `Libmaincil` module (goblint/cil#165).
* Fix some synthetic locations (goblint/cil#166, goblint/cil#167).
@sim642
Copy link
Contributor Author

sim642 commented Jul 30, 2024

The freebsd (experimental) failures seem to be the same as last time: #24812 (comment).

For the goblint packages whose goblint-cil upper bounds this PR changes the failures are:

  1. For freebsd, they're exception Failure("No good preprocessor (cpp) found"), somehow indicating that despite the conf-gcc dependency, there's no cpp binary around. Maybe FreeBSD's gcc package does not install that?
  2. For macos, they're exception Goblint_lib__Maingoblint.FrontendError("Frontc.ParseError: Parse error") which this version of goblint-cil fixes (among other incompatible thing). These failures appear now because MacOS headers have been updated since.

@shonfeder
Copy link
Contributor

Thanks for the error, analysis and the update, @sim642 :)

Assuming that these are not fundamental incompatibilities with the platforms failing on CI, do you think we should either the package to accept those CI failures in the future, and/or add a post-failure message on them indicating how a user could adjust their system to let the installation go thru?

@sim642
Copy link
Contributor Author

sim642 commented Aug 1, 2024

I added some x-ci-accept-failures and availability changes that should be appropriate for these packages.

@mseri
Copy link
Member

mseri commented Aug 2, 2024

Thanks

@mseri mseri merged commit aafa90c into ocaml:master Aug 2, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants