Merge pull request #3109 from OCamlPro/undef-empty

In commands, resolve undefined to "" rather than no argument
ocaml · Nov 23, 2017 · 1764fe7 · 1764fe7
2 parents 612988b + eba5bb5
commit 1764fe7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/doc/pages/Manual.md b/doc/pages/Manual.md
@@ -766,6 +766,9 @@ files.
       detect that the package is not installed from a release tarball, and may
       need additional preprocessing (_e.g._ `automake`).
 
+    If a term is undefined (_e.g._ an undefined variable), the empty string is
+    used as positional argument.
+
 - <a id="opamfield-install">
   `install: [ [ <term> { <filter> } ... ] { <filter> } ... ]`</a>:
   the list of commands that will be run in order to install the package.

diff --git a/src/format/opamFilter.ml b/src/format/opamFilter.ml
@@ -426,7 +426,7 @@ let arguments env (a,f) =
       | Some (S s) -> [s]
       | Some (B b) -> [string_of_bool b]
       | Some (L sl) -> sl
-      | None -> log "ERR in replacement: undefined ident %S" i; []
+      | None -> log "ERR in replacement: undefined ident %S" i; [""]
   else
     []