Mirror changes in channel topic from IRC to Slack. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good |
jvperrin
approved these changes
Oct 5, 2017
slackbridge/bots.py
Outdated
| @@ -101,6 +103,16 @@ def check_slack_rtm(self): | |||
| channel = self.channels[message['channel']] | |||
| return user_bot.post_to_irc('#' + channel['name'], message['text']) | |||
|
|
|||
| def topicUpdated(self, user, channel, newTopic): | |||
There was a problem hiding this comment.
I'd name this something like update_topic instead to stay in the same style with the rest of the methods. Same with newTopic -> new_topic.
There was a problem hiding this comment.
This is an implementation of an event handler in IRCClient that gets called whenever the topic changes or a channel is joined for the first time, so I don't think it's possible to change the name of the function. I can change the topic variable name though.
There was a problem hiding this comment.
Oh, that's awkward, I forgot that's how it works. Maybe put a comment saying that it gets called by twisted when the topic is updated so it's clearer?
Thanks for updating the variable name though.
jvperrin
approved these changes
Oct 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves part of #7