Allow RSCT image to configure runtime via the RSCT spec #23
Conversation
varad-ahirwadkar
force-pushed
the
rsct-image
branch
from
1fd9f8b to
5def1be
Compare
| r.Config.Image = "quay.io/powercloud/rsct-ppc64le:latest" | ||
|
|
||
| // Using the default RSCT image if not specified in RSCTSpec | ||
| if *rsct.Spec.Image == "" { |
There was a problem hiding this comment.
check for nil check before checking for empty string
There was a problem hiding this comment.
Added check for nil instead of empty string
There was a problem hiding this comment.
Now, it is fetching default value. If the spec is empty, the default value will be used.
apiVersion: rsct.ibm.com/v1alpha1
kind: RSCT
metadata:
name: rsct
namespace: rsct-operator-system
spec: {}
a58a977 to
2645516
Compare
varad-ahirwadkar
force-pushed
the
rsct-image
branch
from
2645516 to
5fc73f9
Compare
| r.Config.Namespace = rsct.Namespace | ||
| r.Config.Name = rsct.Name | ||
| r.Config.Image = "quay.io/powercloud/rsct-ppc64le:latest" | ||
| r.Config.Image = *rsct.Spec.Image |
There was a problem hiding this comment.
better have a nil check here for safer side, don't want to hit with NPE
There was a problem hiding this comment.
yes, added nil check
varad-ahirwadkar
force-pushed
the
rsct-image
branch
2 times, most recently
from
202f22c to
0b966e4
Compare
Signed-off-by: Varad Ahirwadkar <[email protected]>
varad-ahirwadkar
force-pushed
the
rsct-image
branch
from
0b966e4 to
ab32ea3
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkumatag, varad-ahirwadkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ppc64le-cloud-bot
merged commit 1b3e7af
into
ocp-power-automation:main
This PR fixes #13 and #12.
This PR allows the RSCT image runtime to be configured via the RSCT spec.