Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating operator's documentation #70

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Updating operator's documentation #70

merged 1 commit into from
Dec 15, 2024

Conversation

varad-ahirwadkar
Copy link
Contributor

@varad-ahirwadkar varad-ahirwadkar commented Nov 28, 2024 •
edited
Loading

Updating the description of the Operator

@varad-ahirwadkar varad-ahirwadkar force-pushed the update-doc branch 3 times, most recently from 9dfbc9a to 3bc1890 Compare December 2, 2024 09:24
@varad-ahirwadkar varad-ahirwadkar changed the title [WIP] Updating operator's documentation Updating operator's documentation Dec 3, 2024
@varad-ahirwadkar
Copy link
Contributor Author

Hi @mkumatag, Currently we have specified the OpenShift Optional category for the operator. Here is the list of categories categories.json. Could you please let me know the most suitable category? Thanks!

@varad-ahirwadkar varad-ahirwadkar mentioned this pull request Dec 3, 2024
Closed
@mkumatag
Copy link
Member

mkumatag commented Dec 3, 2024

Hi @mkumatag, Currently we have specified the OpenShift Optional category for the operator. Here is the list of categories categories.json. Could you please let me know the most suitable category? Thanks!

how about Monitoring?

@varad-ahirwadkar
Copy link
Contributor Author

/hold

@varad-ahirwadkar
Updating operator description
14a5449 
Signed-off-by: Varad Ahirwadkar <[email protected]>
@varad-ahirwadkar
Copy link
Contributor Author

/unhold

@varad-ahirwadkar
Copy link
Contributor Author

Hi @mkumatag, could you please review this PR? Thanks

mkumatag
mkumatag approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

mkumatag
mkumatag approved these changes Dec 15, 2024
View reviewed changes
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkumatag, varad-ahirwadkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot merged commit 9cb6545 into ocp-power-automation:main Dec 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkumatag mkumatag mkumatag approved these changes

Assignees

@mkumatag mkumatag

Labels
approved lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varad-ahirwadkar @mkumatag @ppc64le-cloud-bot